| 1 |
> On 6 Dec 2022, at 21:47, James Le Cuirot <chewi@g.o> wrote: |
| 2 |
> |
| 3 |
> On Tue, 2022-12-06 at 10:12 +0000, Sam James wrote: |
| 4 |
>> [snip] |
| 5 |
>> Lgtm provided you've tested it in the relevant envs (which I'm sure you have). |
| 6 |
>> |
| 7 |
>> Curious how this didn't come up as a problem before, but it |
| 8 |
>> seems fine! |
| 9 |
> |
| 10 |
> econf_build is not widely used, and you only added it to Python in June. It's |
| 11 |
> been used in other packages for much longer, but Python explicitly checks that |
| 12 |
> the size of a long is what it expects. I didn't see it with m68k because we |
| 13 |
> don't have any overrides for that. You also might not see it going from amd64 |
| 14 |
> to arm64 either with them both being 64-bit. The lack of m68k overrides makes |
| 15 |
> me wonder if some of these are even needed any more. ac_cv_sizeof_* can |
| 16 |
> seemingly be determined when cross-compiling now. |
| 17 |
> |
| 18 |
> Since we've already had some reports of success, I'm merging this now. |
| 19 |
|
| 20 |
Thank you for explaining! That makes sense now. |
Archives