| 1 |
internal functions should not be documented with the eclass doc comments |
| 2 |
(_check_build_dir) |
| 3 |
|
| 4 |
reusing a PM variable (ECONF_SOURCE) seems a little iffy |
| 5 |
|
| 6 |
the library handling is incorrect. i dont think you can pass around --enable- |
| 7 |
shared all the time without having configure generate warnings about unknown |
| 8 |
options. default to --disable-static when static-libs doesnt exist is wrong |
| 9 |
-- that's the opposite of what you should be doing. ignoring the same issue |
| 10 |
as the share option i mentioned above. |
| 11 |
|
| 12 |
pushd/popd should have stdout sent to /dev/null, not stderr too |
| 13 |
|
| 14 |
the src_install func has the static-libs checks in the incorrect order |
| 15 |
|
| 16 |
the src_test func looks like its copying & pasting stuff from the PM. this |
| 17 |
really should be kept in the PM without duplicating it everywhere. |
| 18 |
-mike |
Archives