Gentoo Archives: gentoo-dev

From: Sam James <sam@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH 1/6] virtualx.eclass: Add quoting to workaround vim syntax hl bug
Date: Wed, 27 Jul 2022 08:09:10
Message-Id: 73AAED43-0DFC-4D0D-9514-F7737BE18268@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/6] virtualx.eclass: Add quoting to workaround vim syntax hl bug by "Michał Górny"
1 > On 27 Jul 2022, at 08:17, Michał Górny <mgorny@g.o> wrote:
2 >
3 > Signed-off-by: Michał Górny <mgorny@g.o>
4 > ---
5 > eclass/virtualx.eclass | 2 +-
6 > 1 file changed, 1 insertion(+), 1 deletion(-)
7 >
8
9 Please reference the vim bug (guessing it's https://github.com/vim/vim/issues/10673)
10 in the commit message and in the eclass I guess so that we know when it's fixed.
11
12 I love my bug links, okay?
13
14 > diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
15 > index b7a25c897b4a..5c4b39164cff 100644
16 > --- a/eclass/virtualx.eclass
17 > +++ b/eclass/virtualx.eclass
18 > @@ -53,7 +53,7 @@ case ${VIRTUALX_REQUIRED} in
19 > *)
20 > BDEPEND="${VIRTUALX_REQUIRED}? ( ${VIRTUALX_DEPEND} )"
21 > IUSE="${VIRTUALX_REQUIRED}"
22 > - [[ ${VIRTUALX_REQUIRED} == test ]] &&
23 > + [[ ${VIRTUALX_REQUIRED} == "test" ]] &&
24 > RESTRICT+=" !test? ( test )"
25 > ;;
26 > esac
27 > --
28 > 2.35.1
29 >
30 >

Attachments

File name MIME type
signature.asc application/pgp-signature