Gentoo Archives: gentoo-dev

From: Sergei Trofimovich <slyfox@g.o>
To: Matt Turner <mattst88@g.o>
Cc: gentoo-dev@l.g.o, x11@g.o
Subject: Re: [gentoo-dev] [PATCH] xorg-2.eclass: Use --disable-selective-werror.
Date: Sun, 29 Jan 2017 20:00:24
Message-Id: 20170129200003.614d4d58@sf
In Reply to: [gentoo-dev] [PATCH] xorg-2.eclass: Use --disable-selective-werror. by Matt Turner
1 On Sun, 29 Jan 2017 11:42:16 -0800
2 Matt Turner <mattst88@g.o> wrote:
3
4 > Bug: https://bugs.gentoo.org/416069
5 > ---
6 > eclass/xorg-2.eclass | 5 +++++
7 > 1 file changed, 5 insertions(+)
8 >
9 > diff --git a/eclass/xorg-2.eclass b/eclass/xorg-2.eclass
10 > index b7c7ba2..7d681f2 100644
11 > --- a/eclass/xorg-2.eclass
12 > +++ b/eclass/xorg-2.eclass
13 > @@ -468,6 +468,11 @@ xorg-2_src_configure() {
14 > local dep_track="--disable-dependency-tracking"
15 > fi
16 >
17 > + # Check if package supports disabling of selective -Werror=...
18 > + if grep -q -s "disable-selective-werror" ${ECONF_SOURCE:-.}/configure; then
19 > + local dep_track="--disable-selective-werror"
20
21 I guess you planned to use new local var name here (or '+='). Otherwise
22 code will drop --disable-dependency-tracking a few lines above.
23
24 > + fi
25 >
26 > local myeconfargs=(
27 > ${dep_track}
28 > ${FONT_OPTIONS}
29
30 --
31
32 Sergei

Replies