Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-p2p/deluge: ChangeLog deluge-0.5.6.2.ebuild deluge-0.5.6.1.ebuild

[Marijn Schouten (hkBst)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Donnie Berkholz wrote:
> On 15:38 Wed 31 Oct     , Raul Porcel (armin76) wrote:
>> 1.1                  net-p2p/deluge/deluge-0.5.6.2.ebuild
>>
>> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5.6.2.ebuild?rev=1.1&view=markup
>> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5.6.2.ebuild?rev=1.1&content-type=text/plain
>
>> pkg_setup() {
>> 	if has_version "<dev-libs/boost-1.34" && \
>> 		! built_with_use "dev-libs/boost" threads; then
>> 		eerror "dev-libs/boost has to be built with threads USE-flag."
>> 		die "Missing threads USE-flag for dev-libs/boost"
>> 	fi
>> }
>>
>> src_compile() {
>> 	filter-ldflags -Wl,--as-needed
>>
>> 	distutils_src_compile
>> }
>
> If you moved the filter-ldflags() call up to pkg_setup(), you could drop
> src_compile() altogether to clean up the ebuild a little.

Wouldn't that make binary packages cry?

Marijn

- --
Marijn Schouten (hkBst), Gentoo Lisp project
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.7 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHKMiMp/VmCx0OL2wRAuCGAJ9WdFT5k7bGxZCEJOT0hiwjWZafpgCfYh5F
ONjgCrQ0Y8kf7HI/97YU4AU=
=tPfT
-----END PGP SIGNATURE-----
-- 
gentoo-dev@g.o mailing list