Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: scarabeus@g.o
Subject: Re: [gentoo-dev] git-2: a bunch of patches to review
Date: Wed, 21 Sep 2011 09:19:52
Message-Id: 20110921112121.04ec62c2@pomiocik.lan
In Reply to: Re: [gentoo-dev] git-2: a bunch of patches to review by "Tomáš Chvátal"
On Tue, 20 Sep 2011 22:46:10 +0200
Tomáš Chvátal <scarabeus@g.o> wrote:

> 0001 - i had reason to put local definitions on the top, it is way > more readable to see right away what local vars function has, so > please stick to it. > 0007 - I placed it into the conditionals to be clear what is > happening, what if there will be added another if without the push...
Ok, these two fixed/replaced. -- Best regards, Michał Górny


File name MIME type
0001-Replace-variable-eval-s-with-foo.patch text/x-patch
0007-Move-pushd-popds-within-conditional-to-avoid-needles.patch text/x-patch
signature.asc application/pgp-signature