| 1 |
On wto, 2017-07-25 at 12:48 +0000, Peter Stuge wrote: |
| 2 |
> Good work on the refactoring! |
| 3 |
> |
| 4 |
> Alexis Ballier wrote: |
| 5 |
> > > > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then |
| 6 |
> > > |
| 7 |
> > > It’s always been recommended to me that we should use the [[ … ]] |
| 8 |
> > > form. |
| 9 |
> > |
| 10 |
> > Doesn't make much difference here |
| 11 |
> |
| 12 |
> Some; you need neither quote nor {} in expansions within [[ ]]. So |
| 13 |
> instead of the above one could write: |
| 14 |
|
| 15 |
{} is completely irrelevant to [ ] vs [[ ]]. |
| 16 |
|
| 17 |
> |
| 18 |
> if [[ -d $ED/usr/share/doc/$PF/$PN ]]; then |
| 19 |
> |
| 20 |
> |
| 21 |
> > and I've always been recommending the other way :p |
| 22 |
> |
| 23 |
> .. |
| 24 |
> > if you only do ebuilds or bash, then you don't care, but I definitely |
| 25 |
> > do other scripts |
| 26 |
> |
| 27 |
> Be that as it may this is an eclass, and I think conforming to an |
| 28 |
> established coding style has significant value. I too have understood |
| 29 |
> that to be [[ ]]. |
| 30 |
|
| 31 |
...and ${}. |
| 32 |
|
| 33 |
> |
| 34 |
> |
| 35 |
> Thanks |
| 36 |
> |
| 37 |
> //Peter |
| 38 |
> |
| 39 |
|
| 40 |
-- |
| 41 |
Best regards, |
| 42 |
Michał Górny |
Archives