| 1 |
Alex, |
| 2 |
|
| 3 |
Nice work on this, it's looking good now. Is there a reason the |
| 4 |
leading asterisk was dropped? Having it there might be good for |
| 5 |
readability as well as keeping in line with the "look here" (einfo, |
| 6 |
eerror, ewarn, etc) motif in portage. |
| 7 |
|
| 8 |
I will be testing and reporting back my results, encourage others to |
| 9 |
do the same for their terminals as well. |
| 10 |
|
| 11 |
Thanks, |
| 12 |
John |
| 13 |
"Open source, you don't pay back, you pay forward." |
| 14 |
|
| 15 |
On 7/23/06, Alex Tarkovsky <alextarkovsky@×××××.com> wrote: |
| 16 |
> Attached is an overhaul of John's code. Aside from some bugfixes and |
| 17 |
> readability improvements, the most significant changes are: |
| 18 |
> |
| 19 |
> - Renamed functions to follow de facto and emerging Portage API naming |
| 20 |
> conventions. |
| 21 |
> |
| 22 |
> - Validation of input for the list prompt and confirmation prompt functions. |
| 23 |
> |
| 24 |
> - Added more terminal color codes, based on the codes from Portage's |
| 25 |
> output.py module. |
| 26 |
> |
| 27 |
> - Improved handling when Portage's NOCOLOR environment var is set. |
| 28 |
> |
| 29 |
> I've left some test code at the end to make it easy for everyone (and |
| 30 |
> I do mean everyone; this sucker needs a lot of testing) to try out the |
| 31 |
> various interactive prompts this eclass provides -- just run the |
| 32 |
> eclass directly and have fun. You can also run it in no color mode |
| 33 |
> thusly: |
| 34 |
> |
| 35 |
> # NOCOLOR=true ./einput.eclass |
| 36 |
> |
| 37 |
> If your system is already set to no color by default, you should be |
| 38 |
> able to turn on color like so: |
| 39 |
> |
| 40 |
> # NOCOLOR= ./einput.eclass |
| 41 |
> |
| 42 |
> |
| 43 |
> |
| 44 |
-- |
| 45 |
gentoo-dev@g.o mailing list |
Archives