Gentoo Archives: gentoo-dev

From: Fabian Groffen <grobian@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] git-2: a bunch of patches to review
Date: Thu, 22 Sep 2011 07:48:27
Message-Id: 20110922074752.GA38557@gentoo.org
In Reply to: Re: [gentoo-dev] git-2: a bunch of patches to review by Ulrich Mueller
1 On 22-09-2011 09:01:17 +0200, Ulrich Mueller wrote:
2 > > Attaching fixed version of the last two patches, and a complete
3 > > eclass for convenience.
4 >
5 > Just a general comment: Is it really necessary to change all
6 > [[ -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more obscure
7 > [[ ${foo} ]] and [[ ! ${foo} ]]?
8 >
9 > The shortest possible form is not always the one that's best readable.
10
11 +1
12
13 The style used is up to the maintainer.
14
15
16 --
17 Fabian Groffen
18 Gentoo on a different level

Attachments

File name MIME type
signature.asc application/pgp-signature