1 |
On 07/06/2010 12:38 AM, Arfrever Frehtes Taifersar Arahesis wrote: |
2 |
> 2010-07-05 23:28:01 Samuli Suominen napisał(a): |
3 |
>> On 07/05/2010 11:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
4 |
>>> 2010-07-05 21:18:57 Mark Loeser napisał(a): |
5 |
>>>> Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o> said: |
6 |
>>>>> 2010-07-05 20:00:11 Mark Loeser napisał(a): |
7 |
>>>>>> Everyone else has already made valid points. I'm just picking this one |
8 |
>>>>>> to reply to now. Please remove the colors you have added. If you need |
9 |
>>>>>> a new function, say "eqawarn", we should have that added in the next |
10 |
>>>>>> EAPI with a description of when and where to use it. |
11 |
>>>>> |
12 |
>>>>> In case of the colored message added in this patch, if einfo/elog/ewarn/eqawarn/eerror was used, |
13 |
>>>>> then its output wouldn't be logged by Portage. |
14 |
>>>> |
15 |
>>>> I don't understand what you are trying to say. |
16 |
>>> |
17 |
>>> Portage doesn't log output of einfo/elog/ewarn/eqawarn/eerror called in global scope. |
18 |
>> |
19 |
>> Can you point to the location of python.eclass / distutils.eclass where |
20 |
>> you need to send output from global scope, please? |
21 |
> |
22 |
> It's at the beginning of this patch. NEED_PYTHON is parsed in global scope. |
23 |
> |
24 |
|
25 |
OK, so let me get this right... are trying to justify using all of the |
26 |
echo+custom colorization in the eclass by this one occurance, in basis |
27 |
of it doesn't get logged otherwise? |
28 |
|
29 |
Seems a bit far fetch. Also I'm not convinced if it's beneficial to log |
30 |
this. |