Gentoo Archives: gentoo-dev

From: hasufell <hasufell@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] eutils.eclass: Allow to configure base patch location for epatch_user
Date: Sat, 05 Sep 2015 16:16:26
Message-Id: 55EB154A.7030801@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] eutils.eclass: Allow to configure base patch location for epatch_user by Guilherme Amadio
1 On 09/05/2015 06:14 PM, Guilherme Amadio wrote:
2 > On Sat, Sep 05, 2015 at 02:42:15PM +0200, Ulrich Mueller wrote:
3 >>>>>>> On Sat, 5 Sep 2015, Rich Freeman wrote:
4 >>
5 >>> I certainly support the principle, but for the sake of transparency
6 >>> can we try to coordinate this so that the setting name doesn't
7 >>> change when this moves into the package manager for EAPI6?
8 >>
9 >> So far, the EAPI 6 draft says [1]:
10 >>
11 >> eapply_user
12 >> Takes no arguments. Package managers supporting it apply
13 >> user-provided patches to the source tree in the current working
14 >> directory. Exact behaviour is implementation defined and beyond
15 >> the scope of this specification. Package managers not supporting
16 >> it must implement the function as a no-op. Only available in
17 >> EAPIs listed in table [...] as supporting eapply_user.
18 >
19 > Is there a reason to pick eapply_user rather than epatch_user? I think
20 > the second one would fit better with what we already have.
21 > Alternatively, if we would like to avoid adding a new function, it could
22 > be something like epatch --user or epatch -d $DIRECTORY_WITH_PATCHES,
23 > where $DIRECTORY_WITH_PATCHES either defaults to something like
24 > $EPATCH_SOURCE_USER, or can be specified via package.env. This takes the
25 > burden away from the package manager for where to put patches, and lets
26 > the user make that choice.
27 >
28
29 Please start a new thread for discussing EAPI-6 features. This is
30 offtopic here.