Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-dev] [PATCH 1/2] dev-lang/jimtcl: Remove parallel econf code
Date: Mon, 20 Mar 2017 19:36:21
Message-Id: 20170320193552.32500-1-mgorny@gentoo.org
1 The parallel econf code is used only with USE=static-libs, and even in
2 that case provides negligible speed gain. At the same time, it adds
3 a lot of complexity, causes the build logs to be unreadable mix of
4 output from both configure scripts and violates PMS by calling econf
5 in parallel which can cause issues with different package managers.
6 ---
7 dev-lang/jimtcl/jimtcl-0.75-r1.ebuild | 10 ++++------
8 dev-lang/jimtcl/jimtcl-0.76.ebuild | 10 ++++------
9 dev-lang/jimtcl/jimtcl-9999.ebuild | 10 ++++------
10 3 files changed, 12 insertions(+), 18 deletions(-)
11
12 diff --git a/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild b/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild
13 index d05b5040644f..180745bbe7da 100644
14 --- a/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild
15 +++ b/dev-lang/jimtcl/jimtcl-0.75-r1.ebuild
16 @@ -1,9 +1,9 @@
17 -# Copyright 1999-2014 Gentoo Foundation
18 +# Copyright 1999-2017 Gentoo Foundation
19 # Distributed under the terms of the GNU General Public License v2
20
21 EAPI="5"
22
23 -inherit multiprocessing eutils
24 +inherit eutils
25
26 if [[ ${PV} == "9999" ]] ; then
27 EGIT_REPO_URI="http://repo.or.cz/r/jimtcl.git"
28 @@ -40,15 +40,13 @@ src_prepare() {
29 }
30
31 src_configure() {
32 - multijob_init
33 - CCACHE=None multijob_child_init econf --with-jim-shared
34 + CCACHE=None econf --with-jim-shared
35 if use static-libs ; then
36 # The build does not support doing both simultaneously.
37 mkdir static-libs
38 cd static-libs
39 - CCACHE=None ECONF_SOURCE=${S} multijob_child_init econf
40 + CCACHE=None ECONF_SOURCE=${S} econf
41 fi
42 - multijob_finish
43 }
44
45 src_compile() {
46 diff --git a/dev-lang/jimtcl/jimtcl-0.76.ebuild b/dev-lang/jimtcl/jimtcl-0.76.ebuild
47 index a82e24c9b204..ecdcdc96fac5 100644
48 --- a/dev-lang/jimtcl/jimtcl-0.76.ebuild
49 +++ b/dev-lang/jimtcl/jimtcl-0.76.ebuild
50 @@ -1,9 +1,9 @@
51 -# Copyright 1999-2015 Gentoo Foundation
52 +# Copyright 1999-2017 Gentoo Foundation
53 # Distributed under the terms of the GNU General Public License v2
54
55 EAPI="5"
56
57 -inherit multiprocessing eutils
58 +inherit eutils
59
60 if [[ ${PV} == "9999" ]] ; then
61 EGIT_REPO_URI="http://repo.or.cz/r/jimtcl.git"
62 @@ -40,15 +40,13 @@ src_prepare() {
63 }
64
65 src_configure() {
66 - multijob_init
67 - CCACHE=None multijob_child_init econf --with-jim-shared
68 + CCACHE=None econf --with-jim-shared
69 if use static-libs ; then
70 # The build does not support doing both simultaneously.
71 mkdir static-libs
72 cd static-libs
73 - CCACHE=None ECONF_SOURCE=${S} multijob_child_init econf
74 + CCACHE=None ECONF_SOURCE=${S} econf
75 fi
76 - multijob_finish
77 }
78
79 src_compile() {
80 diff --git a/dev-lang/jimtcl/jimtcl-9999.ebuild b/dev-lang/jimtcl/jimtcl-9999.ebuild
81 index d05b5040644f..180745bbe7da 100644
82 --- a/dev-lang/jimtcl/jimtcl-9999.ebuild
83 +++ b/dev-lang/jimtcl/jimtcl-9999.ebuild
84 @@ -1,9 +1,9 @@
85 -# Copyright 1999-2014 Gentoo Foundation
86 +# Copyright 1999-2017 Gentoo Foundation
87 # Distributed under the terms of the GNU General Public License v2
88
89 EAPI="5"
90
91 -inherit multiprocessing eutils
92 +inherit eutils
93
94 if [[ ${PV} == "9999" ]] ; then
95 EGIT_REPO_URI="http://repo.or.cz/r/jimtcl.git"
96 @@ -40,15 +40,13 @@ src_prepare() {
97 }
98
99 src_configure() {
100 - multijob_init
101 - CCACHE=None multijob_child_init econf --with-jim-shared
102 + CCACHE=None econf --with-jim-shared
103 if use static-libs ; then
104 # The build does not support doing both simultaneously.
105 mkdir static-libs
106 cd static-libs
107 - CCACHE=None ECONF_SOURCE=${S} multijob_child_init econf
108 + CCACHE=None ECONF_SOURCE=${S} econf
109 fi
110 - multijob_finish
111 }
112
113 src_compile() {
114 --
115 2.12.0

Replies