[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-sound/cdparanoia: ChangeLog cdparanoia-3.10.2-r3.ebuild

[Samuli Suominen]

On 10/23/2011 03:00 PM, Tomas Chvatal (scarabeus) wrote:
> scarabeus    11/10/23 12:00:55
>
>   Modified:             ChangeLog cdparanoia-3.10.2-r3.ebuild
>   Log:
>   Bump to eapi4 and punt static libs.

Time to revert this commit as I don't see anything in the ebuild that
disables building the static archives at compile phase.

This is same as hiding the problem, not solving it. Not the way we do
things at sound@.

>
>   (Portage version: 2.2.0_alpha70/cvs/Linux x86_64)
>
> Revision  Changes    Path
> 1.103                media-sound/cdparanoia/ChangeLog
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/cdparanoia/ChangeLog?rev=1.103&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/cdparanoia/ChangeLog?rev=1.103&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/cdparanoia/ChangeLog?r1=1.102&r2=1.103
>
> Index: ChangeLog
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/media-sound/cdparanoia/ChangeLog,v
> retrieving revision 1.102
> retrieving revision 1.103
> diff -u -r1.102 -r1.103
> --- ChangeLog	21 Jan 2010 22:46:49 -0000	1.102
> +++ ChangeLog	23 Oct 2011 12:00:55 -0000	1.103
> @@ -1,6 +1,10 @@
>  # ChangeLog for media-sound/cdparanoia
> -# Copyright 1999-2010 Gentoo Foundation; Distributed under the GPL v2
> -# $Header: /var/cvsroot/gentoo-x86/media-sound/cdparanoia/ChangeLog,v 1.102 2010/01/21 22:46:49 abcd Exp $
> +# Copyright 1999-2011 Gentoo Foundation; Distributed under the GPL v2
> +# $Header: /var/cvsroot/gentoo-x86/media-sound/cdparanoia/ChangeLog,v 1.103 2011/10/23 12:00:55 scarabeus Exp $
> +
> +  23 Oct 2011; Tomáš Chvátal <scarabeus@g.o>
> +  cdparanoia-3.10.2-r3.ebuild:
> +  Bump to eapi4 and punt static libs.
>
>    21 Jan 2010; Jonathan Callen <abcd@g.o>
>    cdparanoia-3.10.2-r3.ebuild:
>
>
>
> 1.11                 media-sound/cdparanoia/cdparanoia-3.10.2-r3.ebuild
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/cdparanoia/cdparanoia-3.10.2-r3.ebuild?rev=1.11&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/cdparanoia/cdparanoia-3.10.2-r3.ebuild?rev=1.11&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-sound/cdparanoia/cdparanoia-3.10.2-r3.ebuild?r1=1.10&r2=1.11
>
> Index: cdparanoia-3.10.2-r3.ebuild
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/media-sound/cdparanoia/cdparanoia-3.10.2-r3.ebuild,v
> retrieving revision 1.10
> retrieving revision 1.11
> diff -u -r1.10 -r1.11
> --- cdparanoia-3.10.2-r3.ebuild	21 Jan 2010 22:46:49 -0000	1.10
> +++ cdparanoia-3.10.2-r3.ebuild	23 Oct 2011 12:00:55 -0000	1.11
> @@ -1,8 +1,9 @@
> -# Copyright 1999-2010 Gentoo Foundation
> +# Copyright 1999-2011 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
> -# $Header: /var/cvsroot/gentoo-x86/media-sound/cdparanoia/cdparanoia-3.10.2-r3.ebuild,v 1.10 2010/01/21 22:46:49 abcd Exp $
> +# $Header: /var/cvsroot/gentoo-x86/media-sound/cdparanoia/cdparanoia-3.10.2-r3.ebuild,v 1.11 2011/10/23 12:00:55 scarabeus Exp $
> +
> +EAPI=4
>
> -EAPI=2
>  inherit autotools eutils flag-o-matic libtool toolchain-funcs versionator
>
>  MY_P=${PN}-III-$(get_version_component_range 2-3)
> @@ -14,7 +15,7 @@
>  LICENSE="GPL-2 LGPL-2.1"
>  SLOT="0"
>  KEYWORDS="alpha amd64 arm hppa ia64 ~mips ppc ppc64 sparc x86 ~amd64-linux ~x86-linux"
> -IUSE=""
> +IUSE="static-libs"
>
>  S=${WORKDIR}/${MY_P}
>
> @@ -37,10 +38,10 @@
>  }
>
>  src_compile() {
> -	emake OPT="${CFLAGS}" || die "emake failed"
> +	emake OPT="${CFLAGS}"
>  }
>
>  src_install() {
> -	emake DESTDIR="${D}" install || die "emake install failed"
> -	dodoc README
> +	default
> +	use static-libs || find "${ED}" -name '*.a' -exec rm -f {} +
>  }
>
>
>
>