Re: [gentoo-dev] [PATCH] autotools.eclass: eclassdoc, cosmetic changes, drop old EAPIs

[Michał Górny]

Hi,

Thank you for doing this.  LGTM modulo a few nits below.

On Sat, 2021-03-27 at 22:21 +0000, Sam James wrote:
> -	if [[ ${EBUILD_PHASE} != "unpack" && ${EBUILD_PHASE} != "prepare" ]]; then
> -		ewarn "QA Warning: running $1 in ${EBUILD_PHASE} phase"
> +	if [[ ${EBUILD_PHASE_FUNC} != "src_unpack" && ${EBUILD_PHASE_FUNC} != "src_prepare" ]] ; then

Maybe use 'has' here?

> +		eqawarn "Running '${1}' in ${EBUILD_PHASE_FUNC} phase"
>  	fi
>  
>
>
>
>
>
>
>
>  	if ${missing_ok} && ! type -P ${1} >/dev/null ; then
> -		einfo "Skipping '$*' due $1 not installed"
> +		einfo "Skipping '$*' because '${1}' not installed"

...is not installed?  ;-)


-- 
Best regards,
Michał Górny