Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.
Date: Wed, 11 Dec 2019 06:08:23
Message-Id: w6gtv67wg1n.fsf@kph.uni-mainz.de
In Reply to: [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it. by "Ulrich Müller"
1 >>>>> On Sat, 07 Dec 2019, Ulrich Müller wrote:
2
3 > The eclass failed to remount a read-only mounted /boot, because package
4 > collision sanity checks in recent Portage versions prevented it from
5 > reaching pkg_preinst() at all. Furthermore, with the "mount-sandbox"
6 > feature enabled, the mount won't be propagated past pkg_preinst() and
7 > installed files would end up under the (shadowed) mount point.
8
9 > Therefore don't even attempt to mount /boot ourselves, but error out
10 > if it isn't mounted read/write and ask the user to mount /boot.
11
12 > Also clean up and simplify. (For example, awk is a grown-up program
13 > which doesn't need any help from egrep or sed. :-)
14
15 > Closes: https://bugs.gentoo.org/532264
16 > See-also: https://bugs.gentoo.org/274130#c5
17 > Signed-off-by: Ulrich Müller <ulm@g.o>
18 > ---
19 > v3: Exit awk commands on first match.
20
21 > v4: Added die statements after awk commands
22 > Fixed typo in mount-boot_is_disabled function documentation
23 > Reverted renaming of I_KNOW_WHAT_I_AM_DOING variable
24
25 Pushed (with one small spelling change in an error message).
26
27 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature