[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/csync2: ChangeLog csync2-1.34.ebuild

[Donnie Berkholz]

On 08:49 Thu 20 Sep     , Christian Zoffoli (xmerlin) wrote:
> xmerlin     07/09/20 08:49:25
>
>   Modified:             ChangeLog
>   Added:                csync2-1.34.ebuild
>   Log:
>   Version bump.
>   (Portage version: 2.1.2.2)

> 1.1                  sys-cluster/csync2/csync2-1.34.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-cluster/csync2/csync2-1.34.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-cluster/csync2/csync2-1.34.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
> 	econf \
> 		--localstatedir=/var \
> 		--sysconfdir=/etc/csync2 \
> 		|| die
>
> 	emake || die

These could really use some die() messages, so you know which one failed.

> 	make DESTDIR=${D} \
> 		localstatedir=/var \
> 		sysconfdir=/etc/csync2 \
> 		install || die "install problem"

Use emake here too...

> pkg_config() {
> 	einfo "Updating /etc/services"
> 	{ grep -v ^${PN} /etc/services;
> 	echo "csync2  30865/tcp"
> 	} > /etc/services.new
> 	mv -f /etc/services.new /etc/services
>
> 	if [ ! -f /etc/${PN}/csync2_ssl_key.pem ]; then
> 		einfo "Creating default certificate in /etc/${PN}"
>
> 		openssl genrsa -out /etc/${PN}/csync2_ssl_key.pem 1024 &> /dev/null
>
> 		yes '' | \
> 		openssl req -new \
> 			-key /etc/${PN}/csync2_ssl_key.pem \
> 			-out /etc/${PN}/csync2_ssl_cert.csr \
> 			&> /dev/null
>
> 		openssl x509 -req -days 600 \
> 			-in /etc/${PN}/csync2_ssl_cert.csr \
> 			-signkey /etc/${PN}/csync2_ssl_key.pem \
> 			-out /etc/${PN}/csync2_ssl_cert.pem \
> 			&> /dev/null
>
> 		rm /etc/${PN}/csync2_ssl_cert.csr
> 		chmod 400 /etc/${PN}/csync2_ssl_key.pem /etc/${PN}/csync2_ssl_cert.pem
> 	fi
> }

This function doesn't respect ${ROOT}.

Thanks,
Donnie
-- 
gentoo-dev@g.o mailing list