[gentoo-dev] cmake-utils.eclass: two improvements

[Andrew Savchenko]

Hello all,

I propose two improvements to cmake-utils eclass:

1. Set default documentation directory

cmake allows to specify default docs installation directory
(analogue of --docdir for configure script), but cmake-utils.eclass
does nothing in this regard and many ebuilds in tree contain the
same duplicated code:

-DCMAKE_INSTALL_DOCDIR=/usr/share/doc/${PF}

I propose to add this to the eclass, thus ebuilds can be
simplified. See attached patch.

2. Disable rpath for non-prefix builds

cmake allows to disable RPATH linking (enabled by default), this
leads to insecure rpath warning during install phase checks, logs
show that build directory (-Wl,-rpath /var/tmp/portage/...) is
added to linker options.

Many ebuilds fix this by adding one of the following or similar
options:
-DCMAKE_SKIP_RPATH=ON
-DENABLE_RPATH=OFF
-DCMAKE_BUILD_WITH_INSTALL_RPATH=OFF

I propose to add this functionality to the eclass, thus ebuilds can
be simplified. See attached patch.

Comments?

Best regards,
Andrew Savchenko