Gentoo Archives: gentoo-dev

From: Christian Faulhammer <opfer@g.o>
To: gentoo-dev@l.g.o, hncaldwell@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-misc/anki: metadata.xml Manifest anki-0.9.8.1.ebuild ChangeLog
Date: Fri, 03 Oct 2008 17:09:50
Message-Id: 20081003190902.0c7c0464@terra.solaris
1 Hi,
2
3 welcome to your mentor reviews. :)
4
5 "Heath Caldwell (hncaldwell)" <hncaldwell@g.o>:
6
7 > Index: metadata.xml
8 > <flag name="kakasi">
9 > Enable <pkg>app-i18n/kakasi</pkg> support for
10 > furigana generation </flag>
11
12 I tend to call it furigana instead of kakasi, as USE flags should
13 describe a purpose/function not the needed software to achieve it.
14
15 > Index: anki-0.9.8.1.ebuild
16 > ===================================================================
17 > # Copyright 1999-2008 Gentoo Foundation
18 > # Distributed under the terms of the GNU General Public License v2
19 > #
20 > $Header: /var/cvsroot/gentoo-x86/app-misc/anki/anki-0.9.8.1.ebuild,v
21 > 1.1 2008/10/02 23:13:39 hncaldwell Exp $
22 >
23 > EAPI=1
24 >
25 > NEED_PYTHON=2.4
26 > inherit eutils multilib python
27 >
28 > DESCRIPTION="A spaced-repetition memory training program (flash
29 > cards)" HOMEPAGE="http://ichi2.net/anki/index.html"
30 > SRC_URI="http://ichi2.net/anki/download/${P}.tgz"
31 > LICENSE="GPL-3"
32 > SLOT="0"
33 > KEYWORDS="~amd64 ~x86"
34 > IUSE="+graph kakasi +sound"
35 >
36 > RDEPEND=">=dev-python/PyQt4-4.3
37 > >=dev-python/sqlalchemy-0.4.1
38 > >=dev-python/simplejson-1.7.3
39 > >=dev-python/pysqlite-2.3.0
40
41 pysqlite is included with Python 2.5 (USE=sqlite enabled), so you
42 might upgrade to EAPI=2 and use USE dependencies or add a
43 built_with_use check into pkg_config. Or ask the Python team how to
44 handle it in the best way.
45
46 > src_install() {
47 > dodoc CREDITS
48 >
49 > python_version
50 >
51 > insinto "/usr/$(get_libdir)/python${PYVER}/site-packages"
52 > doins -r ankiqt libanki/anki
53 >
54 > insinto "/usr/$(get_libdir)/python${PYVER}/site-packages/anki"
55 > doins -r designer icons icons.qrc icons_rc.py libanki/samples
56 >
57 > dobin ${PN}
58 >
59 > doicon icons/${PN}.png
60 > make_desktop_entry ${PN} ${PN} ${PN}.png "Education"
61 > }
62
63 No installation routine available?
64
65 V-Li
66
67 --
68 Christian Faulhammer, Gentoo Lisp project
69 <URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
70
71 <URL:http://www.faulhammer.org/>

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies