| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA512 |
| 3 |
|
| 4 |
On 01/25/2016 07:29 AM, Aaron W. Swenson wrote: |
| 5 |
> On 2016-01-24 18:44, Michael Orlitzky wrote: |
| 6 |
>> On 01/24/2016 06:29 PM, Aaron W. Swenson wrote: |
| 7 |
>>> Okay, provided that the new USE_EXPAND is okay for |
| 8 |
>>> POSTGRES_TARGETS, attached are the eclasses that I'll commit to |
| 9 |
>>> the tree. |
| 10 |
>>> |
| 11 |
>> |
| 12 |
>>> case ${EAPI:-0} in 0|1|2|3|4) die "postgres-multi.eclass |
| 13 |
>>> requires EAPI 5 or higher" ;; *) ;; esac |
| 14 |
>> |
| 15 |
>> Does this really work with EAPI=6? I didn't try, but it looks |
| 16 |
>> like it would need an eapply_user somewhere in src_prepare. And, |
| 17 |
>> pedantry warning, there's no such thing as "EAPI 5 or higher." |
| 18 |
>> The lawyers will tell you to do something like this instead |
| 19 |
>> (stolen from git-r3): |
| 20 |
>> |
| 21 |
>> case "${EAPI:-0}" in 5|6) ;; *) die "Unsupported EAPI=${EAPI} |
| 22 |
>> (unknown) for ${ECLASS}" ;; esac |
| 23 |
>> |
| 24 |
>> That will require an edit for every new EAPI, but prevents weird |
| 25 |
>> crashes from things like a missing eapply_user. |
| 26 |
>> |
| 27 |
>> |
| 28 |
> |
| 29 |
> Thank you. |
| 30 |
> |
| 31 |
> I've added the eapply_user to postgres-multi and modified the case |
| 32 |
> condition to match the hot goods you're selling on the sly. |
| 33 |
> |
| 34 |
|
| 35 |
You missed the fix for EAPI in postgres-multi.eclass (it looks okay in |
| 36 |
the other eclass, though). |
| 37 |
|
| 38 |
- -- |
| 39 |
Jonathan Callen |
| 40 |
-----BEGIN PGP SIGNATURE----- |
| 41 |
Version: GnuPG v2 |
| 42 |
|
| 43 |
iQIcBAEBCgAGBQJWpukoAAoJEEIQbvYRB3mgD/8P/iCbnkSZGcwnbQ7EsV55apJ+ |
| 44 |
+AqzVJVbgvNkrK23JysYfDcT9Qthld5W1CX66YBg38PBJbDHrQPZQiAYypybVxo8 |
| 45 |
Liv8P2O4smBdYhIdFfcMw6ARyOpfRec1kiYiZr0YI/sM1pQF/UV2RuG+zJJILMwJ |
| 46 |
f3gNoRN0u58hMX5F1LZn0vRcrp9FqovNy1MMQ83u1qZp6SwK81IZFmHXoyyEWmaO |
| 47 |
zh1plMRfs9iD7DK6CzHBvRyIyShzJGcNLOkNM7qKU5GhAXi7bWuwx5ZZpD1peWLI |
| 48 |
Rn9xXfffyA62eU7EGvUQG/PuAU1PErT9+nFhH6qqSBnOpcR3kFO8a5zgfLHogzJT |
| 49 |
cDQf4XU9MxDCjvSF2c/2tnt1tXqBO7CTjvsaIgaok8vzLsmh6wwJCiqGb80gRWX7 |
| 50 |
4HIAKqH1QbBLfPkb54NQp8ixw1b+LmtcbgJQrpXpxJTrUqtnJKDaaXKblFO8eOW2 |
| 51 |
LeLYYxdzEz3rh6RiqT7NZ3iKKP6cFy7S4qlfe4qsXD7mns1eIqcx9Hdt8LuwDMnC |
| 52 |
zGLb7TBThrhBTt1gRdsXNDZUhkO5YohNqIgeUO1+bEnWS2UGZNf4Mv69HZTgipLO |
| 53 |
vZ2vPFevEW5zAqj8kXgZQjuyrq59TlCY9l2q/etf4oxk6e2Sge1TZ8dcfLA9kJ/E |
| 54 |
SIdeJ4XRl36+p1ANzG6c |
| 55 |
=F4Y9 |
| 56 |
-----END PGP SIGNATURE----- |
Archives