| 1 |
On 07/30/2011 01:42 PM, Zac Medico wrote: |
| 2 |
> Hi everyone, |
| 3 |
> |
| 4 |
> We've found that portage's unpack behavior is inconsistent for non-tar |
| 5 |
> files compressed with gz|Z|z|bz2|bz|lzma|xz extensions [1]. Currently, |
| 6 |
> it emulates tools like gunzip and bunzip2, unpacking them to the |
| 7 |
> directory of the source file. |
| 8 |
> |
| 9 |
> For consistency, we could make it unpack them to cwd instead. PMS |
| 10 |
> already specifies that the files should unpack to cwd, so this change |
| 11 |
> will bring portage and PMS into agreement. Hopefully it won't break too |
| 12 |
> many ebuilds, and we can always add compatibility code to ebuilds, like |
| 13 |
> this: |
| 14 |
> |
| 15 |
> [[ ! -f ${x} ]] && { mv ${x}.gz ./ || die "mv failed"; } |
| 16 |
> |
| 17 |
> Is anyone opposed to making this change? |
| 18 |
> |
| 19 |
> [1] http://bugs.gentoo.org/show_bug.cgi?id=376741 |
| 20 |
|
| 21 |
The PMS compliant unpack behavior is implemented in |
| 22 |
sys-apps/portage-2.1.10.10. |
| 23 |
|
| 24 |
It's unlikely to cause any problems, if any, since the most common |
| 25 |
practice is to unpack source files that are already in the cwd. There |
| 26 |
were only 2 packages in all of gentoo-x86 that needed to be fixed |
| 27 |
because they unpacked files that weren't in the cwd: |
| 28 |
|
| 29 |
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/www-plugins/google-talkplugin/google-talkplugin-2.1.7.0.ebuild?view=log#rev1.3 |
| 30 |
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/games-arcade/tuxpuck/tuxpuck-0.8.2-r1.ebuild?view=log#rev1.7 |
| 31 |
-- |
| 32 |
Thanks, |
| 33 |
Zac |
Archives