Re: [gentoo-dev] [PATCH] eclass/vim-plugin.eclass: delete if has_version condition.

[Patrice Clement]

Thursday 22 Jul 2021 10:54:02, Patrice Clement wrote :
> ... and replace it with a test against the REPLACING_VERSIONS variable.
>
> See https://projects.gentoo.org/pms/8/pms.html#x1-10900011.1.
>
> This is an updated version of the same patch discussed previously on this ML.
>
> Suggested by Arfrever.
> ---
>  eclass/vim-plugin.eclass | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/eclass/vim-plugin.eclass b/eclass/vim-plugin.eclass
> index 6b72d66111d..460edcce3eb 100644
> --- a/eclass/vim-plugin.eclass
> +++ b/eclass/vim-plugin.eclass
> @@ -126,31 +126,31 @@ update_vim_afterscripts() {
>  display_vim_plugin_help() {
>  	local h
>
> -	if ! has_version ${CATEGORY}/${PN} ; then
> -		if [[ -n "${VIM_PLUGIN_HELPFILES}" ]] ; then
> +	if [[ -z ${REPLACING_VERSIONS} ]]; then
> +		if [[ -n ${VIM_PLUGIN_HELPFILES} ]]; then
>  			elog " "
>  			elog "This plugin provides documentation via vim's help system. To"
>  			elog "view it, use:"
> -			for h in ${VIM_PLUGIN_HELPFILES} ; do
> +			for h in ${VIM_PLUGIN_HELPFILES}; do
>  				elog "    :help ${h}"
>  			done
>  			elog " "
>
> -		elif [[ -n "${VIM_PLUGIN_HELPTEXT}" ]] ; then
> +		elif [[ -n ${VIM_PLUGIN_HELPTEXT} ]]; then
>  			elog " "
>  			while read h ; do
>  				elog "$h"
>  			done <<<"${VIM_PLUGIN_HELPTEXT}"
>  			elog " "
>
> -		elif [[ -n "${VIM_PLUGIN_HELPURI}" ]] ; then
> +		elif [[ -n ${VIM_PLUGIN_HELPURI} ]]; then
>  			elog " "
>  			elog "Documentation for this plugin is available online at:"
>  			elog "    ${VIM_PLUGIN_HELPURI}"
>  			elog " "
>  		fi
>
> -		if has "filetype" "${VIM_PLUGIN_MESSAGES}" ; then
> +		if has filetype ${VIM_PLUGIN_MESSAGES}; then
>  			elog "This plugin makes use of filetype settings. To enable these,"
>  			elog "add lines like:"
>  			elog "    filetype plugin on"
> --
> 2.31.1
>
>

Merged. Thanks ulm for the review!