Gentoo Archives: gentoo-dev

From: Florian Schmaus <flow@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] go-module.eclass: undeprecate EGO_SUM
Date: Mon, 13 Jun 2022 10:25:15
Message-Id: c61b7f85-1d3a-1d92-9f18-c614e81da4f5@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH] go-module.eclass: undeprecate EGO_SUM by Andrew Ammerlaan
1 On 13/06/2022 11.49, Andrew Ammerlaan wrote:
2 > On 13/06/2022 09:44, Florian Schmaus wrote:
3 >> Following the gentoo-dev@ mailing list discussion [1], this
4 >> un-deprecates EGO_SUM.
5 >>
6 >> 1:
7 >> https://archives.gentoo.org/gentoo-dev/message/1a64a8e7694c3ee11cd48a58a95f2faa
8 >>
9 >>
10 >> Signed-off-by: Florian Schmaus <flow@g.o>
11 >> ---
12 >>   eclass/go-module.eclass | 30 +++++++++++-------------------
13 >>   1 file changed, 11 insertions(+), 19 deletions(-)
14 >>
15 >> diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass
16 >> index a5dafb45cab8..2e0b7dc1726d 100644
17 >> --- a/eclass/go-module.eclass
18 >> +++ b/eclass/go-module.eclass
19 >> @@ -25,7 +25,9 @@
20 >>   #
21 >>   # If the software has a directory named vendor in its
22 >>   # top level directory, the only thing you need to do is inherit the
23 >> -# eclass. If it doesn't, you need to also create a dependency tarball
24 >> and
25 >> +# eclass. If it doesn't, then you either 1) populate EGO_SUM in the
26 >> ebuild and
27 >> +# call go-module_set_globals as discussed below or 2) you need to
28 >> create a
29 >> +# dependency tarball and
30 >>   # host it somewhere, for example in your dev space.
31 >>   #
32 >>   # Here is an example of how to create a dependency tarball.
33 >
34 > I agree that EGO_SUM shouldn't have been completely deprecated following
35 > the previous discussion. It is not always possible or practical to host
36 > a dependency tarball, especially for people who aren't Gentoo
37 > developers. However, from what I remember from the previous discussion
38 > there actually were some good arguments against using EGO_SUM, mainly
39 > relating to the size of the ebuilds and manifests.
40
41 What's wrong with an ebuild using an EGO_SUM with a few entries in ::gentoo?
42
43 - Florian