Gentoo Archives: gentoo-dev

From: Daniel Pielmeier <billie@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 0/4] Eclass for single-impl Lua ebuilds
Date: Thu, 01 Oct 2020 18:31:20
Message-Id: 9be93928-5e35-8adc-3737-d7dacfbf3896@gentoo.org
In Reply to: [gentoo-dev] [PATCH 0/4] Eclass for single-impl Lua ebuilds by Marek Szuba
1 Marek Szuba schrieb am 30.09.20 um 18:23:
2 > Same as lua.eclass and python-r1, this is a Lua version of
3 > python-single-r1. Setting LUA_SINGLE_TARGETS allows one to choose the
4 > (slotted) Lua implementation to build your ebuild against, optionally
5 > including both single- and multi-implementation Lua packages as
6 > dependencies.
7 >
8
9 Hello Marek!
10
11 First of all thank you very much for your work on the eclasses
12 supporting slotted lua. It is very much appreciated.
13
14 As I am not really capable of doing a review I took your eclasses and
15 tried to use it for app-admin/conky (using lua-single) where new
16 versions already need at least lua-5.2. See the changes below.
17
18 I already had slotted lua 5.1 and 5.3 installed and the modified ebuild
19 built fine with lua-5.3 as before. However when I tried setting
20 LUA_SINGLE_TARGET="lua5-2", lua-5.2 was pulled in as a dependency but
21 conky still built against lua-5.3. The temporary pkg-config environment
22 was set correct but somehow it seems not used. Conky uses cmake and
23 pkg_search_module [1] to detect lua preferring 5.3 over 5.2.
24
25 Am I doing something wrong using the eclass or is there an issue with
26 the lua detection in conky or maybe the the eclass?
27
28 [1]
29 https://github.com/brndnmtthws/conky/blob/master/cmake/ConkyPlatformChecks.cmake
30
31 --- conky-1.11.6.ebuild 2020-09-21 12:32:10.180949870 +0200
32 +++ conky-1.11.6-r1.ebuild 2020-10-01 00:04:13.099147223 +0200
33 @@ -3,7 +3,9 @@
34
35 EAPI=7
36
37 -inherit cmake linux-info readme.gentoo-r1 xdg
38 +LUA_COMPAT=( lua5-{2..3} )
39 +
40 +inherit cmake linux-info lua-single readme.gentoo-r1 xdg
41
42 DESCRIPTION="An advanced, highly configurable system monitor for X"
43 HOMEPAGE="https://github.com/brndnmtthws/conky"
44 @@ -45,7 +47,7 @@
45 weather-metar? ( net-misc/curl )
46 webserver? ( net-libs/libmicrohttpd )
47 xmms2? ( media-sound/xmms2 )
48 - || ( dev-lang/lua:5.3 dev-lang/lua:5.2 )
49 + ${LUA_DEPS}
50 "
51 RDEPEND="
52 ${COMMON_DEPEND}
53 @@ -85,6 +87,8 @@
54
55 pkg_setup() {
56 use ipv6 && linux-info_pkg_setup
57 +
58 + lua-single_pkg_setup
59 }
60
61 src_prepare() {
62
63 --
64 --
65 Daniel Pielmeier

Replies

Subject Author
Re: [gentoo-dev] [PATCH 0/4] Eclass for single-impl Lua ebuilds Marek Szuba <marecki@g.o>