Gentoo Archives: gentoo-dev

From: Aaron Bauman <bman@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: Dropped EAPI 2/3 support in virtualx.eclass
Date: Sun, 07 Jan 2018 15:51:54
Message-Id: 6D4AC35F-7397-44EA-9878-4D7164C976E1@gentoo.org
In Reply to: [gentoo-dev] Re: Dropped EAPI 2/3 support in virtualx.eclass by Duncan <1i5t5.duncan@cox.net>
1 On January 6, 2018 8:11:09 PM EST, Duncan <1i5t5.duncan@×××.net> wrote:
2 >Justin Lecher posted on Sat, 06 Jan 2018 13:23:12 +0000 as excerpted:
3 >
4 >> As there are no consumers [1] of the virtualx.eclass using ancient
5 >EAPIs
6 >> I dropped support for EAPI=2/3
7 >>
8 >> Best,
9 >> Justin
10 >>
11 >> 1)
12 >https://qa-reports.gentoo.org/output/eapi-per-eclass/virtualx.eclass/
13 >>
14 >>
15 >> diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
16 >
17 >Dropped, past tense, the commit is already made to the tree, or will
18 >drop
19 >using that diff, assuming no strong objections here?
20 >
21 >Keep in mind that people may still be using it in the overlays even
22 >when
23 >it's out of the main tree. That isn't on its own a reason to avoid
24 >dropping it from the eclass in the tree, but part of the idea of
25 >posting
26 >such changes here is to at least warn people maintaining overlays that
27 >/might/ use it, so they can either port or grab a copy of the eclass
28 >for
29 >their overlay before the change.
30 >
31 >So that past-tense "dropped", if indeed that's what it was, looks a bit
32 >
33 >rude, not giving notice at all. But if it's "dropped in this patch,
34 >but
35 >this patch not yet applied, so will drop in the tree when it is",
36 >carry-
37 >on with the usual timing, then. =:^)
38 >
39 >(My non-scientific observation seems to indicate at least a week of
40 >notice appears to be the norm, if there's no substantial changes
41 >suggested or a wait requested. If there's a wait requested, for
42 >out-of-
43 >tree I'd say perhaps a month, max, no longer necessary for out-of-tree
44 >unless you simply want to be extra nice, because if nothing else they
45 >can
46 >just grab a copy before the change and if they can't even do /that/ in
47 >a
48 >month... . Beyond that and the old version can always be dug out of
49 >git
50 >if necessary.)
51 >
52 >Either way, thanks for the cleanup. =:^)
53
54 You think a distribution should wait a month for changes in order to not break something that is unsupported? He did give you the diff if you're that concerned.
55 --
56 Sent from my Android device with K-9 Mail. Please excuse my brevity.