Archives
Archives
| From: | Ulrich Mueller <ulm@g.o> | ||
|---|---|---|---|
| To: | Florian Schmaus <flow@g.o> | ||
| Cc: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH] eclass/ruby-fakegem.eclass: depend on virtual/pkgconfig | ||
| Date: | Fri, 20 May 2022 09:09:58 | ||
| Message-Id: | u1qwolgdi@gentoo.org | ||
| In Reply to: | Re: [gentoo-dev] [PATCH] eclass/ruby-fakegem.eclass: depend on virtual/pkgconfig by Florian Schmaus |
||
| 1 | >>>>> On Fri, 20 May 2022, Florian Schmaus wrote: |
| 2 | >> +if [ ${#RUBY_FAKEGEM_EXTENSIONS[@]} -ge 1 ]; then |
| 3 | >> + BDEPEND+=" virtual/pkgconfig " |
| 4 | >> +fi |
| 5 | |
| 6 | > Not sure if we have a policy on this, |
| 7 | |
| 8 | We do. :) |
| 9 | |
| 10 | https://projects.gentoo.org/qa/policy-guide/ebuild-format.html#pg0101 |
| 11 | "Use bash conditions [[ ... ]] rather than POSIX-ish [ ... ] or test |
| 12 | builtin." |
| 13 | |
| 14 | https://devmanual.gentoo.org/tools-reference/bash/index.html#single-versus-double-brackets-in-bash |
| 15 | "Important: The [[ ]] form is generally safer than [ ] and should be |
| 16 | used in all new code." |
| 17 | |
| 18 | > but how about using bash's extended test syntax, i.e., [[ … ]] (which |
| 19 | > the eclass already uses in a few places). |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH] eclass/ruby-fakegem.eclass: depend on virtual/pkgconfig | Hans de Graaff <graaff@g.o> |