Gentoo Archives: gentoo-dev

From: Alexis Ballier <aballier@g.o>
To: gentoo-dev@l.g.o
Cc: ml@g.o, Sam James <sam@g.o>
Subject: Re: [gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip
Date: Mon, 11 Oct 2021 11:13:55
Message-Id: 036da017ca4f68823c309e908276c1394eeb0f06.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip by Sam James
1 On Mon, 2021-10-11 at 06:07 +0100, Sam James wrote:
2 > This breaks at least ocamlopt.
3 >
4 > Closes: https://bugs.gentoo.org/803047
5 > Closes: https://bugs.gentoo.org/811315
6 > Signed-off-by: Sam James <sam@g.o>
7 > ---
8 >  eclass/dune.eclass | 3 +++
9 >  1 file changed, 3 insertions(+)
10 >
11 > diff --git a/eclass/dune.eclass b/eclass/dune.eclass
12 > index 02a8a870ef43e..8a6e01893932a 100644
13 > --- a/eclass/dune.eclass
14 > +++ b/eclass/dune.eclass
15 > @@ -28,6 +28,9 @@ esac
16 >  # Do not complain about CFLAGS etc since ml projects do not use
17 > them.
18 >  QA_FLAGS_IGNORED='.*'
19 >  
20 > +# Breaks with ocamlopt
21 > +RESTRICT="strip"
22 > +
23
24
25
26 err this is a terrible idea to do at such a large scale, esp. since
27 nowadays you can use dostrip -x and provide proper comments as to what
28 and why something breaks when stripped on a case by case basis