public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download: 
* Re: [gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip
  @ 2021-10-11 11:13 99% ` Alexis Ballier
  0 siblings, 0 replies; 1+ results
From: Alexis Ballier @ 2021-10-11 11:13 UTC (permalink / raw
  To: gentoo-dev; +Cc: ml, Sam James

On Mon, 2021-10-11 at 06:07 +0100, Sam James wrote:
> This breaks at least ocamlopt.
> 
> Closes: https://bugs.gentoo.org/803047
> Closes: https://bugs.gentoo.org/811315
> Signed-off-by: Sam James <sam@gentoo.org>
> ---
>  eclass/dune.eclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/eclass/dune.eclass b/eclass/dune.eclass
> index 02a8a870ef43e..8a6e01893932a 100644
> --- a/eclass/dune.eclass
> +++ b/eclass/dune.eclass
> @@ -28,6 +28,9 @@ esac
>  # Do not complain about CFLAGS etc since ml projects do not use
> them.
>  QA_FLAGS_IGNORED='.*'
>  
> +# Breaks with ocamlopt
> +RESTRICT="strip"
> +



err this is a terrible idea to do at such a large scale, esp. since
nowadays you can use dostrip -x and provide proper comments as to what
and why something breaks when stripped on a case by case basis



^ permalink raw reply	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2021-10-11  5:07     [gentoo-dev] [PATCH 1/3] dune.eclass: restrict strip Sam James
2021-10-11 11:13 99% ` Alexis Ballier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox