Re: [gentoo-dev] [PATCH 1/2] eclass: Add first version of lua.eclass

[Azamat Hackimov]

Hello!

Some notes from me.

чт, 3 сент. 2020 г. в 16:37, Marek Szuba <marecki@g.o>:

> +# @ECLASS-VARIABLE: LUA
> +# @DEFAULT_UNSET
> +# @DESCRIPTION:
> +# The absolute path to the current Lua interpreter. This variable is set
> +# automatically in functions called by lua_foreach_impl().
> +#
> +# Example value:
> +# @CODE
> +# /usr/bin/lua5.1

I think there also needs a LUAC variable that points to the current
Lua compiler.

> +# @FUNCTION: lua_get_version
> +# @USAGE: [<impl>]
> +# @DESCRIPTION:
> +# Obtain and print the full version number of the given Lua implementation.
> +# If no implementation is provided, ${ELUA} will be used.
> +#
> +# Please note that this function requires Lua and pkg-config installed,
> +# and therefore proper build-time dependencies need be added to the ebuild.
> +lua_get_version() {
> +       debug-print-function ${FUNCNAME} "${@}"
> +
> +       _lua_export "${@}" LUA_VERSION
> +       echo "${LUA_VERSION}"
> +}

There needs a LUA_MAJOR_VERSION (V variable in lua.pc, i.e. 5.1, 5.2,
5.3) instead of full version (R variable in lua.pc, i.e 5.1.5, 5.2.4).
Some obscure Lua packages are required to define V variable to work
properly.