Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: dilfridge@g.o
Subject: Re: [gentoo-dev] perl-module.eclass: respect CFLAGS, LDFLAGS - please review
Date: Sun, 22 Jun 2014 09:54:47
Message-Id: 20140622115433.0967d62a@pomiot.lan
In Reply to: [gentoo-dev] perl-module.eclass: respect CFLAGS, LDFLAGS - please review by "Andreas K. Huettel"
1 Dnia 2014-06-22, o godz. 11:41:01
2 "Andreas K. Huettel" <dilfridge@g.o> napisał(a):
3
4 > Also people familiar with Perl have voiced doubts if we should meddle with the
5 > perl-module CFLAGS and LDFLAGS at all, maybe making these changes conditional
6 > on something like I_KNOW_WHAT_I_AM_DOING. Hoping for comments.
7
8 Making them conditional would make them pointless.
9
10 Also, how about fixing CC and CXX? That's more important to me than
11 some disrespected CFLAGS :P.
12
13 > Detail discussion and test results follows below the patch.
14 >
15 > =======================================
16 >
17 > Index: perl-module.eclass
18 > ===================================================================
19 > RCS file: /var/cvsroot/gentoo-x86/eclass/perl-module.eclass,v
20 > retrieving revision 1.139
21 > diff -u -B -r1.139 perl-module.eclass
22 > --- perl-module.eclass 30 Mar 2014 19:25:14 -0000 1.139
23 > +++ perl-module.eclass 22 Jun 2014 09:35:16 -0000
24 > @@ -139,6 +139,8 @@
25 > --libdoc= \
26 > --destdir="${D}" \
27 > --create_packlist=0 \
28 > + --config "optimize=${CFLAGS}" \
29 > + --config "lddlflags=-shared ${LDFLAGS}" \
30
31 Tadaam, you just broke Darwin like we did! Look at [1] for some clues,
32 though perl may need different values.
33
34 [1]:https://bugs.gentoo.org/show_bug.cgi?id=513664#c7
35
36 --
37 Best regards,
38 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] perl-module.eclass: respect CFLAGS, LDFLAGS - please review "Andreas K. Huettel" <dilfridge@g.o>