Re: [gentoo-dev] New eclass: openvdb.eclass

[Gerion Entrup]

Friendly ping (or have I missed any discussion channel?).
As a user, I'm really looking forward to see blender >=2.80 in the tree.
According to https://bugs.gentoo.org/689740 this eclass is the main blocker.

Gerion

Am Mittwoch, 27. Mai 2020, 03:40:04 CEST schrieb Adrian Grigo:
> Hello, I am a proxied maintainer of blender and openvdb and wish to propose a new eclass and USE_EXPAND variable to ensure the same version of the openvdb abi is used when building the blender, openvdb and openimageio packages.
>
> The tree currently contains openvdb 4 and 5, and I plan to add 6 and 7 soon to support my new blender PR. Each major release of openvdb has a new ABI, and can also support legacy versions. However only one version can be built at a time, which is passed to cmake through OPENVDB_ABI_VERSION_NUMBER, and produces a library with functions named xxx_7abi5 when building openvdb 7 with support for abi 5. Client packages like blender and openimageio which depend on openvdb and also need to be compiled with the same version number in order to link correctly.
>
> To enforce this I propose to add a new USE_EXPAND variable called OPENVDB_ABI, which is set to the version number the user wants to use in the system eg 5, which expands to openvdb_abi_5. The packages can then append -DOPENVDB_ABI_VERSION_NUMBER=${OPENVDB_ABI} to ensure they pass the same value to cmake.
>
> To reduce the boilerplate code required to ensure that only one supported value is set in OPENVDB_ABI and used by all packages, so I propose to add an eclass to maintain this in one place. Similar to PYTHON_COMPAT, each ebuilds set OPENVDB_COMPAT to specify which legacy ABI they can support. The openvdb.eclass uses it to set global variables OPENVDB_REQUIRED_USE and OPENVDB_SINGLE_USEDEP and verify in pkg_prepare that only one of the openvdb_abi_X flags is set.
>
> Each ebuild sets REQUIRED_USE="${OPENVDB_REQUIRED_USE}" which evaluates to ^^ ( openvdb_abi_3 openvdb_abi_4 ... ) to ensure only one abi is enabled from those it supports.
> They set RDEPEND="openvdb? ( media-gfx/openvdb[${OPENVDB_SINGLE_USEDEP}] )" which evaluates to openvdb_abi_3(-)?,openvdb_abi_4(-)?,... to allow portage to enforce the same abi version is built between all packages.
>
> With a new release of openvdb, I will only need to add it to the openvdb_abi.desc file, to an eclass internal list _OPENVDB_ALL_ABI, and to OPENVDB_COMPAT for each ebuild which supports the new version.
>
> Please review my proposed eclass below. I have tested it works when OPENVDB_ABI is missing, set to invalid values, or set to values that cannot satisfy all package requirements simultaneously, and that the system recompiles all packages when the ABI is changed. It also works when set to appropriate values.
>
> I considered other alternatives during development. It is possible to manually add the expanded REQUIRED_USE and RDEPEND strings to each package, but with each new version of openvdb and multiple client packages to maintain this becomes messy and error prone. The user also needs to set the same openvdb_abi_X flag for each package. While currently there are only three packages which need to be synchronised, any other package which depends on openvdb in future will benefit from this infrastructure.
>
> Also without the USE_EXPAND variable the ebuilds do not have access to the version number to pass to the build system, and need to generate it by testing each USE flag. So I think this is the cleanest solution.
>
> I also looked into slotting openvdb as then packages could specify the slot/subslot required eg openvdb:7/5 but don't think this is possible. This would be a major undertaking as it has a static as well as dynamic core library, another library for python, and the cmake modules that find openvdb use the output of a binary at /usr/bin/vdb_print to determine which version to link against. It would also not centralise the boilerplate code.
>
> For further information and my discussion during development see https://github.com/redchillipadi/ebuild-overlay/issues/4
>
> Please let me know if there is a better solution or improvements are required.
>
> Kind Regards,
> Adrian Grigo
>
>
> # Copyright 1999-2020 Gentoo Authors
> # Distributed under the terms of the GNU General Public License v2
>
> # @ECLASS: openvdb.eclass
> # @MAINTAINER:
> # Adrian Grigo <agrigo2001@×××××××××.au>
> # @ AUTHOR:
> # Author: Adrian Grigo <agrigo2001@×××××××××.au>
> # Based on work of: Michał Górny <mgorny@g.o> and Krzysztof Pawlik <nelchael@g.o>
> # @SUPPORTED_EAPIS: 5 6 7
> # @BLURB: An eclass for OpenVDB to control which ABI version is compiled
> # @DESCRIPTION:
> # The OpenVDB package is a library for sorting and manipulating sparse
> # data structures with dynamic topology as required for use in volume
> # rendering for computer graphics.
> #
> # Each major version of OpenVDB provides an updated ABI, as well as
> # the ability to compile using a legacy version of the ABI.
> # Openvdb 7 can be compiled to support version 5, 6 or 7 of the ABI.
> #
> # However the user needs to choose at compile time which version to
> # build by passing OPENVDB_ABI_VERSION_NUMBER="5" to cmake.
> # It is not possible to support multiple versions concurrently
> # so OpenVDB and all packages depending upon it must be built for the
> # same ABI version. This currently means blender and openvdb, and
> # will also include >=openimageio-2.0 once it is updated
> #
> # The client packages have differing requirements for the ABI support.
> # For example,
> # Openvdb-7 supports 5-7 (older version provide ABI 3 and 4 support)
> # Blender supports ABI 4-7
> # Openimageio-2.0 supports ABI 5-7.
> #
> # To use this eclass, the user should first select which ABI to build
> # and set OPENVDB_ABI USE_EXPAND variable in make.conf.
> #
> # When the client package inherits this eclass, it can use the
> # OPENVDB_COMPAT variable in the ebuild to specify which ABI it
> # supports, and then use the OPENVDB_SINGLE_USEDEP variable that the
> # eclass produces to force the package to link using ABI selected in
> # OPENVDB_ABI
> # eg. openvdb? ( media-gfx/openvdb[${OPENVDB_SINGLE_USEDEP}] )
> # When OPENVDB_COMPAT="X Y" the variable evaluates to
> # openvdb_abi_X(-)? openvdb_abi_Y(-)?
> #
> # The client can pass the ABI version to the build system as follows:
> # append-cppflags -DOPENVDB_ABI_VERSION_NUMBER="${OPENVDB_ABI}"
> #
> # This eclass includes pkg_setup which ensures that the package will
> # only compile if only one openvdb_abi_X USE flag is set
> #
> # @EXAMPLE:
> # The user needs to choose which version of the ABI supports all packages
> # they plan to install. This is then stored in a variable in make.conf
> # eg. OPENVDB_ABI="5" in /etc/portage/make.conf
> #
> # The client packages need to:
> # - inherit this eclass.
> # - list the ABI supported by the package in OPENVDB_COMPAT.
> # - use OPENVDB_REQUIRED_USE to ensure that only one of the
> #   compatible ABI can be selected by the ebuild.
> # - include OPENVDB_SINGLE_USEDEP in RDEPEND to ensure any
> #   dependencies build against a similar ABI.
> # - pass the OPENVDB_ABI version to the package build system
> #
> # @CODE
> # inherit openvdb
> # OPENVDB_COMPAT=( 4 5 6 7 )
> # REQUIRED_USE="openvdb? ( ${OPENVDB_REQUIRED_USE} )"
> # RDEPEND="openvdb? ( media-gfx/openvdb[${OPENVDB_SINGLE_USEDEP}] )"
> #
> # src_configure() {
> #   append-cppflags -DOPENVDB_ABI_VERSION_NUMBER="${OPENVDB_ABI_VERSION}"
> #   ...
> #   cmake-utils_src_configure
> # }
> # @CODE
>
> case "${EAPI:-0}" in
>     0|1|2|3|4)
>         die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
>         ;;
>     5|6|7)
>         # EAPI=5 is required for sane USE_EXPAND dependencies
>         ;;
>     *)
>         die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
>         ;;
> esac
>
> EXPORT_FUNCTIONS pkg_setup
>
> # @ECLASS-VARIABLE: OPENVDB_COMPAT
> # @REQUIRED
> # @DESCRIPTION:
> # This variable contains a list of OpenVDB ABI the package supports.
> # It must be set before the 'inherit' call and has to be an array.
> #
> # Example use:
> # @CODE
> # OPENVDB_COMPAT=( 4 5 6 7 )
> # @CODE
> #
>
> # @ECLASS-VARIABLE: OPENVDB_SINGLE_USEDEP
> # @DESCRIPTION:
> # This is an eclass generated USE-dependency flag which can be used by
> # any package depending on openvdb to ensure the correct ABI version
> # support is built.
> #
> # Example use:
> # @CODE
> # RDEPEND="openvdb? ( media-gfx/openvdb[${OPENVDB_SINGLE_USEDEP}] )"
> # @CODE
> #
> # Example value:
> # @CODE
> # openvdb_abi_3(-)?,openvdb_abi_4(-)?,openvdb_abi_5(-)?...
> # @CODE
>
> # @ECLASS-VARIABLE: OPENVDB_REQUIRED_USE
> # @DESCRIPTION:
> # This is an eclass-generated required use expression which ensures
> # that exactly one openvdb_use_X value has been enabled.
> #
> # Example use:
> # @CODE
> # REQUIRED_USE="${OPENVDB_REQUIRED_USE}"
> # @CODE
> #
> # Example value:
> # @CODE
> # ^^ ( openvdb_abi_3 openvdb_abi_4 openvdb_abi_5 openvdb_abi_6 openvdb_abi_7)
> # @CODE
>
> # @ECLASS-VARIABLE: _OPENVDB_ALL_ABI
> # @INTERNAL
> # @DESCRIPTION:
> # All supported OpenVDB ABI
> # Update this with each new major version release of OpenVDB
> _OPENVDB_ALL_ABI=(
>     3 4 5 6 7
> )
> readonly _OPENVDB_ALL_ABI
>
> # @FUNCTION: _openvdb_set_globals
> # @INTERNAL
> # @DESCRIPTION:
> # Ensure that OPENVDB_COMPAT is valid and generate the
> # OPENVDB_REQUIRED_USE and OPENVDB_SINGLE_USEDEP global variables for
> # use by the inheriting ebuild
> _openvdb_set_globals() {
>     local i
>
>     if ! declare -p OPENVDB_COMPAT &>/dev/null; then
>         die 'OPENVDB_COMPAT not declared.'
>     fi
>
>     if [[ $(declare -p OPENVDB_COMPAT) != "declare -a"* ]]; then
>         die 'OPENVDB_COMPAT must be an array.'
>     fi
>
>     local flags=()
>         for i in "${_OPENVDB_ALL_ABI[@]}"; do
>         if has "${i}" "${OPENVDB_COMPAT[@]}"; then
>             flags+=( "openvdb_abi_${i}" )
>         fi
>         done
>
>     if [[ ${#supp[@]} -eq 1 ]]; then
>         IUSE="+${flags[0]}"
>     else
>         IUSE="${flags[*]}"
>     fi
>
>     if [[ ! ${#flags[@]} ]]; then
>         die "No supported OpenVDB ABI in OPENVDB_COMPAT."
>     fi
>
>     local single_flags="${flags[@]/%/(-)?}"
>     local single_usedep=${single_flags// /,}
>
>     OPENVDB_REQUIRED_USE="^^ ( ${flags[*]} )"
>     OPENVDB_SINGLE_USEDEP="${single_usedep}"
>     readonly OPENVDB_REQUIRED_USE OPENVDB_SINGLE_USEDEP
> }
> _openvdb_set_globals
> unset -f _openvdb_set_globals
>
> if [[ ! ${_OPENVDB} ]]; then
>
> # @FUNCTION: openvdb_setup
> # @DESCRIPTION
> # Ensure one and only one OpenVDB ABI version is selected
> openvdb_setup() {
>     debug-print-function ${FUNCNAME} "${@}"
>
>     local i, version
>     for i in "${_OPENVDB_ABI[@]}"; do
>         if use "openvdb_abi_${i}"; then
>             if [[ ${version} ]]; then
>                 eerror "Your OPENVDB_ABI setting lists more than a single OpenVDB"
>                 eerror "ABI version. Please set it to just one value."
>                 echo
>                 die "More than one ABI in OPENVDB_ABI."
>             fi
>         fi
>
>         version="${i}"
>         echo "Using OpenVDB ABI ${version} to build"
>     done
>
>     if [[ ! ${version} ]]; then
>         eerror "No OpenVDB ABI Version selected for the system. Please set"
>         eerror "the OPENVDB_ABI variable in your make.conf to one"
>         eerror "of the values contained in all of:"
>         eerror
>         eerror "- the entire list of ABI: ${_OPENVDB_ALL_ABI[*]}"
>         eerror "- the ABI supported by this package: ${OPENVDB_COMPAT}"
>         eerror "- and the ABI supported by all other packages on your system"
>         echo
>         die "No supported OpenVDB ABI version in OPENVDB_ABI."
>     fi
> }
>
> # @FUNCTION: openvdb_pkg_setup
> # @DESCRIPTION:
> # Runs openvdb_setup.
> openvdb_pkg_setup() {
>     debug-print-function ${FUNCNAME} "${@}"
>
>     [[ ${MERGE_TYPE} != binary ]] && openvdb_setup
> }
>
> _OPENVDB=1
> fi
>
>
>