Gentoo Archives: gentoo-dev

From: Peter Volkov <pva@g.o>
To: gentoo-dev@l.g.o, fordfrog@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-util/netbeans: ChangeLog netbeans-6.5-r1.ebuild netbeans-6.5.ebuild
Date: Sat, 22 Nov 2008 19:03:07
Message-Id: 1227380563.25392.17.camel@localhost
1 В Сбт, 22/11/2008 в 18:11 +0000, Miroslav Sulc (fordfrog) пишет:
2 > fordfrog 08/11/22 18:11:25
3 > Added: netbeans-6.5-r1.ebuild
4 > Log: netbeans compiles fine even with JDK 1.6 so I dropped the restriction on JDK, also commons-fileupload linking fixed
5
6 > Index: netbeans-6.5-r1.ebuild
7 > ===================================================================
8 > pkg_setup() {
9 > if use netbeans_modules_apisupport && ! ( use netbeans_modules_harness && use netbeans_modules_ide && use netbeans_modules_java ) ; then
10 > eerror "'apisupport' USE flag requires 'harness', 'ide' and 'java' USE flags"
11 > exit 1
12 > fi
13
14 Why do you use exit 1 instead of die?
15
16 > local tmpfileplatform="${T}/platform.txt"
17 > cat ${tmpfile} | grep -v "libs.jna/external/jna-3.0.2.jar" > ${tmpfileplatform}
18 > mv ${tmpfileplatform} ${tmpfile}
19
20 grep can read files on it's own so no need for cat file | grep... Also possibly
21
22 sed -e "/libs\.jna\/external\/jna-3\.0\.2\.jar/d" -i ${tmpfile}
23
24 will work better here and in some other places...
25
26 --
27 Peter.

Replies