Re: [gentoo-dev] [PATCH 0/6] s390 restructuring + common mixin for arches without Rust

[Sam James]

> On 19 Jun 2022, at 11:03, Michał Górny <mgorny@g.o> wrote:
>
> Hi,
>
> Here's a patchset doing two things:
>
> 1. Restructuring s390 profiles so that s390 and s390x trees are more
>   independent, and top-level arch/s390 includes only common stuff.
>   This avoids the current ping-pong of masking stuff in s390 just
>   to unmask it in s390x.
>
> 2. Adding a common "feature" profile (i.e. effectively a mixin)
>   common to architectures (and subprofiles) that aren't supported
>   by Rust.  This saves us from duplicating the same (or a little
>   different) masks all over the place.
>
> This patch series can also be found on MicrosoftⓇ GitHubⓇ:
> https://github.com/gentoo/gentoo/pull/25951

I need to review the details just to check for any errors (and I'll do that now),
but conceptual ACK, and unless you hear otherwise, LGTM.

And I like the name (wd40). It's a nice bit of Gentoo "personality"
which some folks say we're lacking nowadays ;)

Thanks for working on this. It'll make life a lot easier for the
platforms which aren't support Rust. Might even make it easier
to "support" systems w/o e.g. SSE2.

(For non-technical observers: this is an internal mechanism
to allow easily referencing "no Rust" settings, rather than
creating a profile for users to actually easily opt in to
removing Rust. Although in theory you may add it to
a custom profile and add it as a parent.)

Best,
sam