Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Thomas Bracht Laumann Jespersen <t@×××××××.xyz>
Cc: gentoo-dev@l.g.o, vim@g.o
Subject: Re: [gentoo-dev] [PATCH 1/2] vim-doc.eclass: support EAPI 8
Date: Wed, 06 Apr 2022 10:55:20
Message-Id: w6gh77632io.fsf@kph.uni-mainz.de
In Reply to: [gentoo-dev] [PATCH 1/2] vim-doc.eclass: support EAPI 8 by Thomas Bracht Laumann Jespersen
1 >>>>> On Wed, 06 Apr 2022, Thomas Bracht Laumann Jespersen wrote:
2
3 > - find $d/doc -name \*.txt -type l | while read s; do
4 > - [[ $(readlink "$s") = $vimfiles/* ]] && rm -f "$s"
5 > + find ${d}/doc -name \*.txt -type l | while read s; do
6 > + [[ $(readlink "${s}") = $vimfiles/* ]] && rm -f "${s}"
7
8 This would profit from a "|| die" statement.
9
10 > - einfo "Removing $d"
11 > - rm -r "$d"
12 > + einfo "Removing ${d}"
13 > + rm -r "${d}"
14
15 Ditto.
16
17 > - if [[ -d $vimfiles/doc ]]; then
18 > - ln -s $vimfiles/doc/*.txt $d/doc 2>/dev/null
19 > + if [[ -d "${vimfiles}"/doc ]]; then
20 > + ln -s "${vimfiles}"/doc/*.txt "${d}/doc" 2>/dev/null
21
22 Ditto.
23
24 Ulrich

Replies

Subject Author
Re: [gentoo-dev] [PATCH 1/2] vim-doc.eclass: support EAPI 8 Anna Vyalkova <cyber+gentoo@×××××.in>