Re: [gentoo-dev] CUSTOM cflags replacement snippet

[Aron Griffis]

Chris,

Chris White wrote:	[Sat Nov 20 2004, 01:14:46AM EST]
> Go ahead and flame, just thought I'd toss it here to make people's lives
> 2% easier :).

As was mentioned later in the thread, this is not the right approach.
Sedding the Makefiles is error-prone because you use a variable in the
RHS of the sed expression.  Whether it works for you in your limited
tests is irrelevant.  You shouldn't be willingly inserting error-prone
code into ebuilds.

There are two different ways you can deal with the CFLAGS issue
instead.  Both are better than the sed method.

1. If the Makefiles are well-constructed and flags are appropriate
   passed to sub-makes, then you can do:

        emake CFLAGS="${CFLAGS}" CXXFLAGS="${CXXFLAGS}"

2. If the Makefiles do lazy assignment of variables instead of
   immediate assignment, then you can simply append a new assignment
   to the bottom of the ebuild.  Here is the comparison of lazy vs.
   immediately assignment:

        # lazy assignment
        CFLAGS = -g

        # immediate assignment
        CFLAGS := -g

   Almost all Makefiles use lazy assignment.  In that case you can use
   a snippet like the following which will override all previous
   assignments in the ebuild:

        find "${S}" -name Makefile | while read mf; do
            printf "\n\nCFLAGS = %s\nCXXFLAGS = %s\n" \
                "${CFLAGS}" "${CXXFLAGS}" >> "$mf"
        done

Regards,
Aron

--
Aron Griffis
Gentoo Linux Developer