[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: eclass/

[Michał Górny]

On Fri, 20 May 2016 19:47:55 +0000 (UTC)
"Johannes Huber" <johu@g.o> wrote:

> commit:     548f4ee19c6b0fe0d5e87e84a5a82c421229e0ce
> Author:     Michael Palimaka <kensington <AT> gentoo <DOT> org>
> AuthorDate: Fri May 20 19:46:11 2016 +0000
> Commit:     Johannes Huber <johu <AT> gentoo <DOT> org>
> CommitDate: Fri May 20 19:47:15 2016 +0000
> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=548f4ee1
>
> kde5.eclass: install all translations when LINGUAS is undefined
>
> This mirrors the behaviour of the gettext autotools macros.
>
> Gentoo-bug: 581382
>
> Signed-off-by: Johannes Huber <johu <AT> gentoo.org>
>
>  eclass/kde5.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eclass/kde5.eclass b/eclass/kde5.eclass
> index 377d2c5..eaffb9e 100644
> --- a/eclass/kde5.eclass
> +++ b/eclass/kde5.eclass
> @@ -397,7 +397,7 @@ kde5_src_prepare() {
>
>  	# enable only the requested translations
>  	# when required
> -	if [[ -d po ]] ; then
> +	if [[ -d po && -v LINGUAS ]] ; then
>  		pushd po > /dev/null || die
>  		for lang in *; do
>  			if [[ -d ${lang} ]] && ! has ${lang} ${LINGUAS} ; then

This doesn't really make any difference since per EAPI 6 all USE_EXPAND
variables (incl. LINGUAS) are always defined. The only reason it seems
to work for you is due to a Portage bug.

-- 
Best regards,
Michał Górny
<http://dev.gentoo.org/~mgorny/>