Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Cc: Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>
Subject: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/traits: traits-3.4.0.ebuild
Date: Sun, 20 Jun 2010 22:27:32
Message-Id: 201006201827.01782.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in dev-python/traits: traits-3.4.0.ebuild by Arfrever Frehtes Taifersar Arahesis
1 On Sunday, June 20, 2010 09:55:39 Arfrever Frehtes Taifersar Arahesis wrote:
2 > 2010-06-19 22:53:37 Mike Frysinger napisał(a):
3 > > On Thursday, June 10, 2010 16:45:29 Arfrever Frehtes Taifersar wrote:
4 > > > 2010-06-10 22:20:44 Nirbheek Chauhan napisał(a):
5 > > > > On Fri, Jun 11, 2010 at 1:30 AM, Arfrever Frehtes Taifersar wrote:
6 > > > > > 2010-06-10 21:27:40 Jeremy Olexa napisał(a):
7 > > > > >> I see no reason to *not* add a ChangeLog entry here.
8 > > > > >
9 > > > > > ChangeLog entries are not required for trivial changes.
10 > > > >
11 > > > > A "trivial" change is fixing a typo, or a manifest problem, a missing
12 > > > > quotation mark, etc. Anything else is not "trivial".
13 > > > >
14 > > > > Anything that changes how an ebuild functions, what it does, or the
15 > > > > installed files (and/or their contents) is NOT a trivial change.
16 > > >
17 > > > This commit only removed some compiler warnings.
18 > >
19 > > mucking with CFLAGS without documentation is wrong. compiler warnings
20 > > come and go, so a flag that was relevant one day could be completely
21 > > extraneous the next.
22 > >
23 > > however, especially with strict aliasing, you arent "just fixing
24 > > warnings", you're changing optimization behavior of gcc to workaround
25 > > broken C code. this obviously does not fall anywhere near the "trivial"
26 > > mark.
27 > >
28 > > i see you still havent fixed this, so get on it already. a bug needs to
29 > > be opened somewhere to get the package properly *fixed*
30 >
31 > This problem is probably caused by bugs in Python 2, which have been fixed
32 > in Python 3.
33
34 the new information you've provided here only reinforces the fact the current
35 code is wrong. properly document the append-flags and properly restrict it to
36 when python-2 is being used.
37
38 considering python-2 is going to be in our lives for a while, how hard is it
39 to backport the changes in question to the headers ? presumably it's
40 struct/union/cast shuffling in the headers.
41 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies