1 |
|
2 |
|
3 |
> On 28 Mar 2021, at 13:46, Ulrich Mueller <ulm@g.o> wrote: |
4 |
> |
5 |
> |
6 |
>>>>>>> On Sun, 28 Mar 2021, David Seifert wrote: |
7 |
>> This is just bringing it in line with the rest of the eclass. You know, |
8 |
>> consistency. |
9 |
> |
10 |
> If that's the goal then the patch should update all occurences, though. |
11 |
|
12 |
Well, that was definitely the aim. To avoid any doubt, I don’t feel particularly passionate about which style we use so it was not the main point of this patch. Just copying existing style for consistency. |
13 |
|
14 |
> Especially those where usage is inconsistent within the same line. |
15 |
|
16 |
I’m mobile right now but maybe you could show me what you’re referring to? Thank you! |
17 |
|
18 |
We have review for a reason - to improve - but being vague doesn’t help me do that ;) |