Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 02/44] apache-module.eclass: Set @PROVIDES
Date: Thu, 02 Sep 2021 14:29:46
Message-Id: 9fc5403ae757fbc98bcad6aeafec36207b86c855.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 02/44] apache-module.eclass: Set @PROVIDES by Michael Orlitzky
1 On Thu, 2021-09-02 at 09:50 -0400, Michael Orlitzky wrote:
2 > On Thu, 2021-09-02 at 14:58 +0200, Michał Górny wrote:
3 > > >
4 > > Apparently, need_apache* is the problem. Most of the ebuilds in www-
5 > > apache/* are calling it:
6 > >
7 >
8 > The apache-module eclass tells you to do that because it needs some of
9 > those APACHE_* paths. It should really be figuring them out itself
10 > rather than telling the user to call a function that does it in global
11 > scope. It's an easy fix:
12 >
13 > APXS=apxs
14 > APACHE_MODULESDIR=$(apxs -q libexecdir)
15 > APACHE_MODULES_CONFDIR=$(apxs -q sysconfdir)/modules.d
16 > APACHE_VHOSTS_CONFDIR=$(apxs -q sysconfdir)/vhosts.d
17 >
18 > On the one hand, we probably don't want ebuild maintainers trying to
19 > solve that themselves when the eclass could do it. But for whatever
20 > such a promise is worth, it also feels wrong to promise that apache-
21 > module will provide all of depend.apache -- what if we someday apply
22 > the fix above to apache-module and want to drop the depend.apache
23 > inherit?
24 >
25 > If we do ever update apache-module, updating ebuilds and retiring
26 > depend.apache would be a lot easier if you could find the candidates
27 > with `git grep depend.apache`, rather than having to look through all
28 > consumers of apache-module for implicit uses of depend.apache.
29 >
30
31 Ok, I've removed this commit from my branch. If maintainers want it
32 otherwise, it's easy enough to do it again.
33
34 --
35 Best regards,
36 Michał Górny