[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-apps/baselayout: ChangeLog baselayout-1.12.10-r5.ebuild

[Christian Faulhammer]

"Mike Frysinger (vapier)" <vapier@g.o>:

>   Modified:             ChangeLog
>   Added:                baselayout-1.12.10-r5.ebuild
>   Log:
>   Add workaround for net.eth0 going AFK during upgrade to
> baselayout-2. (Portage version: 2.1.3.9)
 
> 	# Use correct path to filefuncs.so on multilib systems
> 	sed -i -e "s:/lib/rcscripts:/$(get_libdir)/rcscripts:" \
> 		${S}/src/awk/{cachedepends,genenviron}.awk || die
> }
>
> src_compile() {
[...]
> 	make -C "${S}"/src \
> 		CC="$(tc-getCC)" \
> 		LD="$(tc-getCC) ${LDFLAGS}" \
> 		CFLAGS="${CFLAGS}" \
> 		LIBDIR="${libdir}" || die
> }

 Could use a die message...no emake here?

[...]
> 	kdir ${PORTDIR}

 Could use quotes.

> remap_dns_vars() {
[...]
> 		sed -e 's/\<domain_/dns_domain_/g' \
> 			-e 's/\<mac_domain_/mac_dns_domain_/g' \
> 			-e 's/\<nameservers_/dns_servers_/g' \
> 			-e 's/\<mac_nameservers_/mac_dns_servers_/g' \
> 			-e 's/\<searchdomains_/dns_search_domains_/g'
> \ -e 's/\<mac_searchdomains_/mac_dns_search_domains_/g' \
> 			${ROOT}/etc/conf.d/${f} > ${D}/etc/conf.d/${f}

 Could use quotes.

> pkg_preinst() {
[...]
> 		rm -f ${ROOT}/etc/modules.conf
[...]
> 	rm -f ${ROOT}/etc/._cfg????_gentoo-release
> 	echo "Gentoo Base System release ${PV}" >
> ${ROOT}/etc/gentoo-release
[...]
> 	for f in ${ROOT}etc/init.d/net.* ; do
[...]
> 	if sed -e 's/#.*//' ${ROOT}/etc/conf.d/{net,wireless}
> 2>/dev/null \ | egrep -q '\<(domain|nameservers|searchdomains)_' ;
> 2>then
[...]
> 	if sed -e 's/#.*//' ${ROOT}/etc/conf.d/net 2>/dev/null \


 Could use quotes.

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://www.faulhammer.org/>