Gentoo Archives: gentoo-dev

From: "Justin Lecher (jlec)" <jlec@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 5/9] check-reqs.eclass: Replace obsolete df option -m with -B ###
Date: Mon, 28 Dec 2015 14:16:32
Message-Id: 56814433.4030206@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 5/9] check-reqs.eclass: Replace obsolete df option -m with -B ### by Andrew Savchenko
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 On 28/12/15 14:58, Andrew Savchenko wrote:
5 > Hi,
6 >
7 > On Mon, 28 Dec 2015 09:43:51 +0100 Justin Lecher wrote:
8 >> Signed-off-by: Justin Lecher <jlec@g.o> ---
9 >> eclass/check-reqs.eclass | 2 +- 1 file changed, 1 insertion(+), 1
10 >> deletion(-)
11 >>
12 >> diff --git a/eclass/check-reqs.eclass b/eclass/check-reqs.eclass
13 >> index 138bfec..a32f8f8 100644 --- a/eclass/check-reqs.eclass +++
14 >> b/eclass/check-reqs.eclass @@ -306,7 +306,7 @@ check-reqs_disk()
15 >> { ${size} \ "disk space at \"${path}\""
16 >>
17 >> - space_megs=$(df -Pm "${1}" 2>/dev/null | awk 'FNR == 2 {print
18 >> $4}') + space_megs=$(df -P -B 1048576 "${1}" 2>/dev/null | awk
19 >> 'FNR == 2 {print $4}')
20 >
21 > Why not "-BM"? IMHO, this will be more readable, though, of
22 > course, both arguments are semantically correct.
23 >
24
25 Because the output is different to the original version.
26
27 $ (0) df -Pm /
28 Filesystem 1048576-blocks Used Available Capacity Mounted on
29 /dev/root 47244 25665 19157 58% /
30 $ (0) df -P -B 1048576 /
31 Filesystem 1048576-blocks Used Available Capacity Mounted on
32 /dev/root 47244 25665 19157 58% /
33 $ (0) df -P -BM /
34 Filesystem 1048576-blocks Used Available Capacity Mounted on
35 /dev/root 47244M 25665M 19157M 58% /
36 -----BEGIN PGP SIGNATURE-----
37 Version: GnuPG/MacGPG2 v2.0
38
39 iQJ8BAEBCgBmBQJWgUQzXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
40 ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ0QUU0N0I4NzFERUI0MTJFN0EyODE0NUFF
41 OTQwMkE3OUIwMzUyOUEyAAoJEOlAKnmwNSmiAEUP/RQJRmOaXjUD5orDBpXj/nvj
42 CszwErjdwR43HwEsWeNVGMX1dXd0l1KM5p8tK5d4cn2u920VG8U8ef+SsfJhmfbn
43 tnlM7hOhLmWZOqp57YpLeOvEpz0gqfjgKw3b/5Ywg4ISacufgAwNxbsSBnEmqQYv
44 wETPveQAVETa0SoKD3Ki9PLRVVMN1t+/azMc9hn7+Tm2dth0QoF2sQ3Tm5VbQG/H
45 BfQ4IWAUgpSrU991uliOt7kVTXTEShScSVPVACNoU63qtbNrYU92XGlDCAzPBsjp
46 E8l7jdrlHXlgqu8zh+wvrJ/1qw3t3eqnB96pGe8HAfhdeJ6cVd3mNZITMNmmRl/G
47 IaIdQ1dZlQLmP1ywK3bxS0ehi4XCmaQJKxP0vNAcnrlY41ea8qHp6UhrHT69c+Nr
48 WKCKmanfaadsoLQkHgFiy4kGuXna20XyBdyr1zP9y6L8aSz8Cq6WbESkFu3aNgFT
49 FTNOW4Z6fFwEc/Le3Kaowk8arv9E7yryjkqWzl4EO2nwUReg/4UmfkqgBCSOFh0z
50 JUd1Xvoaeo6hiSEw/VmL+D/HCzlm7Z+SRtNKDR3d8gsyCY0lVMBZscBYdSpAKbn2
51 5RkkynZdR52Y+1cr8Rt9G7Uz+AaX82L19+WgYd9y5dcUynNJgDU5+SRFT1/hZfSR
52 eO0pNmZ9ywefEvYh/2Mc
53 =4hR/
54 -----END PGP SIGNATURE-----