Gentoo Archives: gentoo-dev

From: James Le Cuirot <chewi@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH 0/4] llvm.eclass: EAPI 7 support
Date: Fri, 24 May 2019 17:50:45
Message-Id: 0535EB53-CC49-4B20-BC72-E4ABC89167E0@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 0/4] llvm.eclass: EAPI 7 support by "Michał Górny"
1 On 24 May 2019 05:59:29 BST, "Michał Górny" <mgorny@g.o> wrote:
2 >On Tue, 2019-04-30 at 07:38 +0200, Michał Górny wrote:
3 >> Hi,
4 >>
5 >> Here's my proposed EAPI 7 support for llvm.eclass. I think it should
6 >> conceptually work with cross but I haven't tested it. The main
7 >problem
8 >> is that we have multiple distinct ways of building LLVM, and AFAIU
9 >> when using CMake modules, you should be able to get away without
10 >having
11 >> LLVM in CBUILD. However, when using llvm-config you obviously need
12 >> it CBUILD-executable.
13 >>
14 >> To support both scenarios, get_llvm_prefix is now provided with '-b'
15 >> and '-d' options (matching those to has_version). Using them, you
16 >can
17 >> choose the behavior suitable for your package.
18 >>
19 >> I've left the default at '-d'. I don't really know which is better
20 >> for the generic cross case but either way should work for non-cross
21 >> setups.
22 >>
23 >> --
24 >> Best regards,
25 >> Michał Górny
26 >>
27 >> Michał Górny (4):
28 >> llvm.eclass: Remove unnecessary '_rc' from < example
29 >> llvm.eclass: Update examples for newer LLVM versions
30 >> llvm.eclass: Add EAPI 7 API to get_llvm_prefix
31 >> llvm.eclass: Enable EAPI 7
32 >>
33 >> eclass/llvm.eclass | 65
34 >+++++++++++++++++++++++++++++++++++++---------
35 >> 1 file changed, 53 insertions(+), 12 deletions(-)
36 >>
37 >
38 >Merged.
39
40 I know you made the necessary change in PMS for SYSROOT to work in pkg_setup but I don't think it's been fixed in Portage yet?
41 --
42 Sent from my Android device with K-9 Mail. Please excuse my brevity.