Re: [gentoo-dev] [PATCHES] multilib-build: use MULTILIB_ABI for eclass-specific ABI value

[Michał Górny]

On Wed, 03 Apr 2013 11:40:31 +0200
Thomas Sachau <tommy@g.o> wrote:

> Michał Górny schrieb:
> > Hello,
> >
> > Currently, the multilib-build eclass uses abi_* constants only for USE
> > flags and only ${ABI} is exported to the function. This is bad since it
> > basically requires a reverse mapping of ABI->abi_* values, often
> > inlined as ${ABI} checks.
> >
> > The patches which I will send in reply to this thread aim to fix it.
> >
> > The first patch changes the eclass logic. The abi_* values, with 'abi_'
> > prefix stripped, are called MULTILIB_ABI now. They are used to run
> > the 'foreach' functions, and now are set in the called functions along
> > with ABI.
> >
> > As a downside, the switch required the MULTILIB_ABI -> ABI mapping to
> > occur inside foreach -- as in, another 'for' loop. It shouldn't cause
> > any noticeable difference.
> >
> > Additionally, the 'default' fallback no longer calls
> > multilib_toolchain_setup. This should improve compatibility with
> > multilib-portage and *maybe* cross-compiling.
>
> You know, that multilib-portage does use MULTILIB_ABI as USE-expanded
> variable? Using exactly the same in the eclass will call for collision
> issues.

Argv. Could you suggest a new name then?

-- 
Best regards,
Michał Górny