Gentoo Archives: gentoo-dev

From: Marek Szuba <marecki@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] acct-*.eclass: Create sysusers.d files
Date: Mon, 31 Aug 2020 13:04:07
Message-Id: b48b40d3-fbae-d614-bb9e-c902f9051177@gentoo.org
In Reply to: [gentoo-dev] [PATCH] acct-*.eclass: Create sysusers.d files by "Michał Górny"
1 On 2020-08-29 21:53, Michał Górny wrote:
2
3 > + newins - ${CATEGORY}-${ACCT_USER_NAME}.conf < <(
4 > + printf "u\t%q\t%q\t%q\t%q\t%q\n" \
5 > + "${ACCT_USER_NAME}" \
6 > + "${ACCT_USER_ID/#-*/-}:${ACCT_USER_GROUPS[0]}" \
7 > + "${DESCRIPTION//[:,=]/;}" \
8
9 Maybe it's a fault in how I have tested this (i.e. in an interactive
10 bash session, by setting all the variables and copy-pasting the relevant
11 printf lines by hand) but for me this results in an unquoted GECOS
12 string with spaces escaped with backslashes, whereas sysusers.d(5)
13 explicitly states this should be enclosed in quotation marks. Could you
14 double-check, please?
15
16 Otherwise LGTM.
17
18 --
19 MS

Attachments

File name MIME type
signature.asc application/pgp-signature