Gentoo Archives: gentoo-dev

From: Sam James <sam@g.o>
To: gentoo-dev@l.g.o
Cc: prefix@g.o, toolchain@g.o, Sam James <sam@g.o>, "Aaron W . Swenson" <titanofold@g.o>
Subject: [gentoo-dev] [PATCH 2/2] multilib.eclass: add comment on get_libdir usage in main @DESCRIPTION
Date: Sun, 14 Aug 2022 17:58:43
Message-Id: 20220814175807.1984711-2-sam@gentoo.org
In Reply to: [gentoo-dev] [PATCH 1/2] prefix.eclass: don't redundantly define EPREFIX as an eclass variable by Sam James
1 I see this mistake quite often still and I think it's worth
2 pointing out that multilib.eclass should not be inherited
3 purely for get_libdir.
4
5 Reported-by: Aaron W. Swenson <titanofold@g.o>
6 Signed-off-by: Sam James <sam@g.o>
7 ---
8 eclass/multilib.eclass | 2 ++
9 1 file changed, 2 insertions(+)
10
11 diff --git a/eclass/multilib.eclass b/eclass/multilib.eclass
12 index e3c0d78a6e43..32b23c4ec52b 100644
13 --- a/eclass/multilib.eclass
14 +++ b/eclass/multilib.eclass
15 @@ -8,6 +8,8 @@
16 # @BLURB: This eclass is for all functions pertaining to handling multilib configurations.
17 # @DESCRIPTION:
18 # This eclass is for all functions pertaining to handling multilib configurations.
19 +# (For legacy EAPIs, this eclass was often needed for get_libdir. get_libdir is
20 +# provided by EAPI 6+ and hence this eclass isn't needed for that.)
21
22 case ${EAPI} in
23 6|7|8) ;;
24 --
25 2.37.2