Gentoo Archives: gentoo-dev

From: James Le Cuirot <chewi@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] Add EAPI=8 support
Date: Sun, 10 Apr 2022 20:30:15
Message-Id: 30d9db2b95df59f5545be7fd556abb0194ef7acd.camel@gentoo.org
In Reply to: [gentoo-dev] [PATCH] Add EAPI=8 support by Conrad Kostecki
1 On Sun, 2022-04-10 at 21:22 +0200, Conrad Kostecki wrote:
2 > Signed-off-by: Conrad Kostecki <conikost@g.o>
3 > ---
4 > eclass/cdrom.eclass | 6 +++---
5 > 1 file changed, 3 insertions(+), 3 deletions(-)
6 >
7 > diff --git a/eclass/cdrom.eclass b/eclass/cdrom.eclass
8 > index bae3888c6c5..81539e8560c 100644
9 > --- a/eclass/cdrom.eclass
10 > +++ b/eclass/cdrom.eclass
11 > @@ -1,10 +1,10 @@
12 > -# Copyright 1999-2021 Gentoo Authors
13 > +# Copyright 1999-2022 Gentoo Authors
14 > # Distributed under the terms of the GNU General Public License v2
15 >
16 > # @ECLASS: cdrom.eclass
17 > # @MAINTAINER:
18 > # games@g.o
19 > -# @SUPPORTED_EAPIS: 6 7
20 > +# @SUPPORTED_EAPIS: 6 7 8
21 > # @BLURB: Functions for CD-ROM handling
22 > # @DESCRIPTION:
23 > # Acquire CD(s) for those lovely CD-based emerges. Yes, this violates
24 > @@ -16,7 +16,7 @@
25 > # The functions are generally called in src_unpack.
26 >
27 > case ${EAPI:-0} in
28 > - [67]) ;;
29 > + 6|7|8) ;;
30 > *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
31 > esac
32
33 That's fine, the commit message aside. There's nothing particularly API-
34 specific about this eclass.
35
36 On a sidenote, if all the consumers get bumped to EAPI 8 then we can revert
37 1e09cba657ccb2b8, which fixed the eclass for Bash 4.2 and 4.3, but made it a
38 tiny bit more complex. EAPI 8 requires Bash 5.0.

Attachments

File name MIME type
signature.asc application/pgp-signature