Re: [gentoo-dev] [PATCH] eutils.eclass: add optfeature() function

[Michał Górny]

Dnia 2014-01-25, o godz. 10:12:26
Markos Chandras <hwoarang@g.o> napisał(a):

> On 01/23/2014 04:48 PM, Michał Górny wrote:
> > Dnia 2014-01-23, o godz. 11:36:06
> > Chris Reffett <creffett@g.o> napisał(a):
> >
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> On 01/23/2014 11:28 AM, Michał Górny wrote:
> >>> Dnia 2014-01-23, o godz. 11:24:41 Chris Reffett
> >>> <creffett@g.o> napisał(a):
> >>>
> >>>> After some discussion on good ways to communicate optional
> >>>> dependencies to users, I was shown the optfeature() function in
> >>>> net-misc/netctl. Gentoo contributor Andrew Hamilton and I came up
> >>>> with a cleaned up and expanded version of it, and I would like to
> >>>> add it to eutils.eclass to provide a standard way of notifying
> >>>> users of optional dependencies. The patch to eutils.eclass is
> >>>> attached.
> >>>
> >>> This was discussed already:
> >>>
> >>> http://thread.gmane.org/gmane.linux.gentoo.devel/72162
> >>>
> >> First of all, this is a short patch for a function, not a full eclass.
> >
> > Ah, sorry, this changes *a lot*. Let's start the bikeshed again then,
> > whatever.
> >
> I haven't looked at the implementation, but I wonder if we need a
> function for such trivial stuff. Most maintainers deal with this problem
> using pkg_postinst() einfo/elog messages. Why do we need a dedicated
> function for that? Just for consistency reasons...?

The intent of the original optfeature implementation was to provide
users with nice, colorful '[installed]' messages whenever the optional
dependency was installed.

-- 
Best regards,
Michał Górny