Gentoo Archives: gentoo-dev

From: desultory <desultory@g.o>
To: gentoo-dev@l.g.o, "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH 2/3] xorg-2.eclass: Remove use of prune_libtool_files
Date: Sat, 23 Feb 2019 04:30:41
Message-Id: efe6f232-e6bb-b276-bef2-891c3fa3db69@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH 2/3] xorg-2.eclass: Remove use of prune_libtool_files by "Michał Górny"
1 On 02/20/19 02:36, Michał Górny wrote:
2 > On Wed, 2019-02-20 at 07:20 +0100, Ulrich Mueller wrote:
3 >>>>>>> On Wed, 20 Feb 2019, Matt Turner wrote:
4 >>
5 >>
6 >>> # Don't install libtool archives (even for modules)
7 >>> - prune_libtool_files --all
8 >>> + find "${D}" -name '*.la' -delete || die
9 >>
10 >> Maybe restrict removal to regular files, i.e. add "-type f"?
11 >
12 > I suppose you should have spoken up when people started adopting that
13 > 'find' line all over the place. Though I honestly doubt we're going to
14 > see many packages installing '*.la' non-files.
15 >
16 Just so we are all clear here: your argument is that more fully correct
17 approaches should not be considered in the present and future because
18 less fully correct approaches were implemented in the past? And,
19 further, that since nothing matching a specific pattern happens to come
20 to your mind at he moment, such things do not exist? Perhaps dialing
21 back the rhetoric from 11 and considering feedback as an opportunity to
22 improve existing code is called for in this case, among others.

Replies