1 |
On Wed, Jun 20, 2018 at 11:33:53PM +0100, James Le Cuirot wrote: |
2 |
> On Wed, 20 Jun 2018 17:21:09 -0500 |
3 |
> "Marty E. Plummer" <hanetzer@×××××××××.com> wrote: |
4 |
> |
5 |
> > On Wed, Jun 20, 2018 at 09:03:44PM +0800, Jason Zaman wrote: |
6 |
> > > On Wed, Jun 20, 2018 at 02:10:50AM -0500, Marty E. Plummer wrote: |
7 |
> > > > Use ${EROOT%/} whereever possible, as the tools and directories which |
8 |
> > > > are used with it are already prefixed with a / |
9 |
> > > > |
10 |
> > > > Package-Manager: Portage-2.3.40, Repoman-2.3.9 |
11 |
> > > > --- |
12 |
> > > > eclass/xdg-utils.eclass | 10 +++++----- |
13 |
> > > > 1 file changed, 5 insertions(+), 5 deletions(-) |
14 |
> > > > |
15 |
> > > > diff --git a/eclass/xdg-utils.eclass b/eclass/xdg-utils.eclass |
16 |
> > > > index ac075185d8e..8dba5ed6861 100644 |
17 |
> > > > --- a/eclass/xdg-utils.eclass |
18 |
> > > > +++ b/eclass/xdg-utils.eclass |
19 |
> > > > @@ -66,7 +66,7 @@ xdg_environment_reset() { |
20 |
> > > > # Updates the .desktop files database. |
21 |
> > > > # Generates a list of mimetypes linked to applications that can handle them |
22 |
> > > > xdg_desktop_database_update() { |
23 |
> > > > - local updater="${EROOT}${DESKTOP_DATABASE_UPDATE_BIN}" |
24 |
> > > > + local updater="${EROOT%/}${DESKTOP_DATABASE_UPDATE_BIN}" |
25 |
> > > |
26 |
> > > Shouldn't things like this be $BROOT since they're being run? $EROOT |
27 |
> > > might be a different architecture that may or may not run at all on the |
28 |
> > > build machine. |
29 |
> > > |
30 |
> > Good point, but here's a question; if EROOT=${ROOT%/}${EPREFIX}, how do |
31 |
> > we use BROOT here? EBROOT? Or longhand ${BROOT%/}${EPREFIX} ? I think |
32 |
> > that may be a use case that got missed in the EAPI 7 discussions. |
33 |
> |
34 |
> BROOT is already prefixed as BROOT without a prefix would just be /. |
35 |
> |
36 |
I don't follow. Its my understanding that BROOT ~= ROOT for most |
37 |
situations. But consider this setup: |
38 |
Ubuntu amd64 with Gentoo Prefix, emerging a native arm @system to |
39 |
/mnt/arm EPREFIX = /home/user/gentoo. |
40 |
|
41 |
In this situation, ROOT=/mnt/arm, EROOT=/mnt/arm, but what is BROOT? /, |
42 |
or /home/usr/gentoo? |
43 |
> -- |
44 |
> James Le Cuirot (chewi) |
45 |
> Gentoo Linux Developer |