Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: hasufell@g.o
Subject: Re: [gentoo-dev] [RFC] Initial python-r1.eclass & distutils-r1.eclass
Date: Sat, 29 Sep 2012 18:37:03
Message-Id: 20120929203551.5561af1c@pomiocik.lan
In Reply to: Re: [gentoo-dev] [RFC] Initial python-r1.eclass & distutils-r1.eclass by hasufell
1 On Sat, 29 Sep 2012 15:49:32 +0200
2 hasufell <hasufell@g.o> wrote:
3
4 > -----BEGIN PGP SIGNED MESSAGE-----
5 > Hash: SHA1
6 >
7 > On 09/29/2012 12:49 PM, Michał Górny wrote:
8 > > On Sat, 29 Sep 2012 11:20:31 +0100 Markos Chandras
9 > > <hwoarang@g.o> wrote:
10 > >
11 > >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512
12 > >>
13 > >> On 09/29/2012 09:53 AM, Micha? Górny wrote:
14 > >>> Hello,
15 > >>>
16 > >>> Instead of the floating patches and p-d-ng modifications I sent
17 > >>> earlier, here are the two complete (so far, well, initial :P)
18 > >>> eclasses for review.
19 > >>>
20 > >>> They are designed as 'mostly' drop-in python-distutils-ng
21 > >>> replacement.
22 > >>>
23 > >> Hi,
24 > >>
25 > >> Are you saying that you are going to remove the
26 > >> python-distutils-ng eclass in favour of the new eclasses? I don't
27 > >> quite understand the reasons to be honest.
28 > >
29 > > The reason is simple -- I can't fix it without changing the API.
30 > > Changing the API on a live eclass is confusing, and considering
31 > > that it is not used by many packages, it's easier to lastrite it.
32 > >
33 > > Also, this fixes the name not to have any '-ng' nor '-ds9'.
34 > >
35 >
36 > What are the reasons to change the API in the first place? There has
37 > to be a good reason, cause this will involve yet another migration of
38 > many ebuilds. I don't see any bugreports.
39
40 I have pointed out what changes to the API are _necessary_ to introduce
41 a good eclass on gentoo-python@.
42
43 Otherwise, the eclass would have to have at least two almost identical
44 functions doing the same thing, one universal and one for specific case
45 where specific parameters are passed (and not used in a single ebuild).
46
47 > I fear this will cause more confusion, i.e. some ebuilds using the old
48 > distutils, some using python-distutils-ng and some using distutils-r1
49 > resulting in weird tree behavior.
50
51 [example needed]
52
53 --
54 Best regards,
55 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature