Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: vapier@g.o, constanze@g.o
Subject: Re: [gentoo-dev] fcaps.eclass: bringing filesystem capabilities to the tree
Date: Sat, 26 Jan 2013 13:21:11
Message-Id: 20130126142137.1f2a728c@pomiocik.lan
In Reply to: [gentoo-dev] fcaps.eclass: bringing filesystem capabilities to the tree by Mike Frysinger
1 On Fri, 25 Jan 2013 18:51:44 -0500
2 Mike Frysinger <vapier@g.o> wrote:
3
4 > # Or set it via the global ebuild var FILECAPS:
5 > # @CODE
6 > # FILECAPS=(
7 > # cap_net_raw bin/ping bin/ping6
8 > # )
9 > # @CODE
10
11 Please don't. We have enough eclasses randomly exporting
12 pkg_postinst().
13
14 The FILECAPS array consumes the same amount of space as pkg_postinst()
15 phase declaration. There's no real benefit to this automagic.
16
17 Yet, the phase function exported is *forced* to every single eclass
18 consumer. Therefore, you are implicitly adding lines for people who
19 will have to make sure that every single other pkg_postinst() you
20 clobbered is called.
21
22 Of course, assuming people would actually notice some of the other
23 useless pkg_postinst() phases being clobbered...
24
25 --
26 Best regards,
27 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies