Re: [gentoo-dev] "Trivial" commit reviews

[Mike Doty]

Donnie Berkholz wrote:
> Mike Doty (KingTaco) just told me I could stop sending reviews to -dev
> that are just about adding quotes or other trivial issues that come up
> over and over. I'm going to tell you why it's still a good thing.
>
> First, where one problem lurks, others often do too. In code with such
> simple problems, it's likely that more complex problems also exist.
> Getting more eyes on problematic code of any sort can help find them.
>
> Second, as we've already seen, no one developer is familiar with all the
> code. Both Mike Frysinger and Daniel Drake have responded to some of my
> reviews, pointing out further problems with the same code.
>
> Third, by continuing to post these reviews, it should become obvious to
> _all_ developers that they should be checking for them _before_
> committing instead of waiting for a review.
>
> Over time, the number of these simple reviews should go dramatically
> down so it no longer bothers anyone to see them. If it doesn't, that
> means some of our developers aren't learning or paying attention, and we
> should take a closer look at whether they should remain developers.
>
> Thanks,
> Donnie
My concern is that if we flood -dev with "trivial" commit problems then 
more people will stop watching -dev and/or resort to killfiles or other 
filtering.  While I do agree with Donnies assessment, my concern is that 
over a longer time period, it might have a negative effect.

-- 
=======================================================
Mike Doty                      kingtaco -at- gentoo.org
Gentoo Infrastructure
Gentoo/AMD64 Strategic Lead
GPG: E1A5 1C9C 93FE F430 C1D6  F2AF 806B A2E4 19F4 AE05
=======================================================
-- 
gentoo-dev@g.o mailing list